Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Building with scala 3 #342

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Building with scala 3 #342

wants to merge 13 commits into from

Conversation

raboof
Copy link
Contributor

@raboof raboof commented Jul 22, 2021 •
edited

Fixes #341

@raboof raboof mentioned this pull request Jul 22, 2021
Open
@jrudolph
Copy link
Member

I added a fix for the self-type issue but the tests don't compile cleanly any more, mostly because the new version of specs is not syntax compatible with the old.

@raboof
Copy link
Contributor Author

raboof commented Jul 22, 2021

I added a fix for the self-type issue

Nice!

but the tests don't compile cleanly any more, mostly because the new version of specs is not syntax compatible with the old.

Ah, we can use a cross-dependency for the tests etorreborre/specs2#848

@jrudolph
Copy link
Member

Cool, I fixed all the compilation issues but now it seems that

  • some printing facility changed, now escaping unicode characters
  • ProductFormats don't work any more, probably because Scala compilation changed the way fields are encoded

@jrudolph
Copy link
Member

ProductFormats don't work any more, probably because Scala compilation changed the way fields are encoded

Ultimately, we would want to use derivation in Scala 3, but I guess it would be nice to support it in a simpler way until then?

@jrudolph
fix ProductFormats reflection
fbd903b
@jrudolph
fix unicode tests
a363745 
\u unicode encodes don't seem to supported any more in Scala 3 (at least
in tripple quoted strings)
@jrudolph
Copy link
Member

jrudolph commented Sep 9, 2021

Fixed the remaining issues, was pretty trivial after all.

@raboof raboof mentioned this pull request Nov 16, 2021
Closed
50 tasks
@raboof
mima
6aa89c8
@raboof
Skip mima for 2.10
402e46b 
Since it's not supported anymore. While we'll still publish
2.10 artifacts, perhaps it's fine to stop checking binary
compatibility.
@raboof raboof changed the title WIP quick experiment building with scala 3 Building with scala 3 Nov 16, 2021
@raboof raboof marked this pull request as ready for review November 16, 2021 12:30
@raboof
Copy link
Contributor Author

raboof commented Nov 16, 2021

/cc @jrudolph this might now be good to go?

@raboof raboof requested a review from jrudolph November 18, 2021 13:49
raboof added a commit to raboof/spray-json that referenced this pull request Dec 7, 2021
@raboof
Building with scala 3 (backport)
b5ef49b 
Backport of spray#342 to the release-1.3.x branch
@raboof raboof mentioned this pull request Dec 7, 2021
Merged
raboof added a commit that referenced this pull request Dec 9, 2021
@raboof
Building with scala 3 (backport) (#345)
a2b4986 
Backport of #342 to the release-1.3.x branch
@hughsimpson
Copy link

Is this dead?

@raboof
Copy link
Contributor Author

raboof commented Jul 25, 2023

With #345 merged and https://repo1.maven.org/maven2/io/spray/spray-json_3/1.3.6/ published this PR isn't so urgent anymore - the project is in 'maintainance mode' (https://github.com/spray/spray-json#maintanance-mode) and perhaps there won't even really be a need for a 1.4.x release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrudolph jrudolph Awaiting requested review from jrudolph

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@raboof @jrudolph @hughsimpson