Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

example doc for enum and case objects #336

Open
wants to merge 1 commit into
base: release/1.3.x
Choose a base branch
from

Conversation

davideicardi
Copy link

I have tried to add some documentation example on how to implement json formats for enumeration and case object types.

I think that both are quite common in Scala and providing an official example can be useful.

Copy link
Contributor

@raboof raboof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems helpful to me

@ndlarsen
Copy link

This was actually quite helpful to me. Thank you

```scala
import spray.json._

class EnumJsonFormat[T <: scala.Enumeration](enu: T) extends RootJsonFormat[T#Value] {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the lib owners can't merge this EnumJsonFormat class to make it official?

@waagnermann
Copy link

And on PR itself: why it's still not merged if @raboof and @ndlarsen say it's helpful?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants