Spotaut 18392 - Implementation for Verification Provider OceanCD #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chandra1-n
reviewed
May 9, 2024
|
|
||
| output, err := spotinstClient.oceancd.ReadVerificationProvider(ctx, input) | ||
| if err != nil { | ||
| // If the cluster was not found, return nil so that we can show that it |
There was a problem hiding this comment.
please modify the message
chandra1-n
reviewed
May 9, 2024
| } | ||
|
|
||
| // Some other error, report it. | ||
| return nil, fmt.Errorf("ocean/aks: failed to read verification provider: %v", err) |
There was a problem hiding this comment.
modify the error message
chandra1-n
reviewed
May 9, 2024
spotinst/oceancd_verification_provider/fields_spotinst_oceancd_verification_provider.go
Outdated
Show resolved
Hide resolved
chandra1-n
reviewed
May 9, 2024
chandra1-n
reviewed
May 9, 2024
...rification_provider_cloud_watch/fields_spotinst_oceancd_verification_provider_cloud_watch.go
Outdated
Show resolved
Hide resolved
chandra1-n
reviewed
May 9, 2024
...rification_provider_cloud_watch/fields_spotinst_oceancd_verification_provider_cloud_watch.go
Outdated
Show resolved
Hide resolved
chandra1-n
reviewed
May 9, 2024
chandra1-n
reviewed
May 9, 2024
...eancd_verification_provider_datadog/fields_spotinst_oceancd_verification_provider_datadog.go
Show resolved
Hide resolved
chandra1-n
reviewed
May 9, 2024
chandra1-n
reviewed
May 9, 2024
...eancd_verification_provider_jenkins/fields_spotinst_oceancd_verification_provider_jenkins.go
Show resolved
Hide resolved
chandra1-n
reviewed
May 9, 2024
chandra1-n
reviewed
May 9, 2024
chandra1-n
reviewed
May 9, 2024
chandra1-n
reviewed
May 9, 2024
chandra1-n
reviewed
May 9, 2024
chandra1-n
reviewed
May 9, 2024
chandra1-n
reviewed
May 9, 2024
chandra1-n
requested changes
May 9, 2024
chandra1-n
reviewed
May 11, 2024
go.mod
Outdated
| @@ -1,6 +1,6 @@ | |||
| module github.com/spotinst/terraform-provider-spotinst | |||
|
|
|||
| go 1.20 | |||
| go 1.18 | |||
There was a problem hiding this comment.
please change back this to 1.20
chandra1-n
requested changes
May 11, 2024
chandra1-n
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the default pull request template. You can customize it by adding a
pull_request_template.mdat the root of your repo or inside the.githubfolder.Jira Ticket
Include a link to your Jira Ticket
Example: JIRAISS-1234
Demo
Please add a recording of the feature/bug fix in work. if you added new routes, the recording should show the request and response for each new/changed route
Checklist: