Silence false positive UnconsumedParameterWarning #3235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
starhel
force-pushed
the
fix-unconsumed-parameter-warning
branch
from
8b621ee
to
6c5a463
Compare
starhel
force-pushed
the
fix-unconsumed-parameter-warning
branch
from
370789a
to
59a3bcd
Compare
|
@andresgomezfrr Do you have any idea how to fix codecov? |
dlstadther
approved these changes
Jun 8, 2023
@starhel Could you try to update this branch with master? |
starhel
force-pushed
the
fix-unconsumed-parameter-warning
branch
from
59a3bcd
to
e77375d
Compare
|
Branch was updated, I've forced CI to retest PR. edit: codecov python package is no longer supported: https://github.com/codecov/codecov-python. |
Do not emit UnconsumedParameterWarning when parameter name is written in camelCase or with dashes.
…ging parameters in core config.
starhel
force-pushed
the
fix-unconsumed-parameter-warning
branch
from
e77375d
to
b877047
Compare
dlstadther
approved these changes
Sep 7, 2023
|
Apologies for not merging this sooner! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UnconsumedParameterWarning is emitted even if parameters are correctly consumed.
Description
There are two cases when UnconsumedParameterWarning is false positive:
Motivation and Context
False positive UnconsumedParameterWarning forced me to completely disable this feature as any output to stderr is treated as error in pipelines.
Have you tested this? If so, how?
I've added unitests and tested this branch in my pipeline.