Skip to content
This repository has been archived by the owner on Mar 27, 2021. It is now read-only.

[core] Close fetch / fetchSeries spans #680

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[core] Close fetch / fetchSeries spans #680

wants to merge 2 commits into from

Conversation

lmuhlha
Copy link
Member

@lmuhlha lmuhlha commented Jul 23, 2020

No description provided.

Copy link
Contributor

@malish8632 malish8632 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jul 23, 2020

Codecov Report

Merging #680 (c08c248) into master (4ab6620) will decrease coverage by 0.55%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #680      +/-   ##
============================================
- Coverage     54.41%   53.86%   -0.56%     
+ Complexity     3053     2961      -92     
============================================
  Files           735      726       -9     
  Lines         19868    19428     -440     
  Branches       1304     1279      -25     
============================================
- Hits          10812    10465     -347     
+ Misses         8590     8517      -73     
+ Partials        466      446      -20     
Impacted Files Coverage Δ Complexity Δ
.../spotify/heroic/tracing/EndSpanFutureReporter.java 35.71% <ø> (ø) 2.00 <0.00> (ø)
.../com/spotify/heroic/metric/LocalMetricManager.java 68.35% <0.00%> (+2.27%) 4.00 <0.00> (ø)
...igtable/credentials/DefaultCredentialsBuilder.java 66.66% <0.00%> (-33.34%) 2.00% <0.00%> (-1.00%)
.../com/spotify/heroic/common/ValueOptionalLimit.java 40.74% <0.00%> (-14.82%) 17.00% <0.00%> (-3.00%)
...com/spotify/heroic/aggregation/simple/MaxBucket.kt 44.44% <0.00%> (-11.12%) 4.00% <0.00%> (-1.00%)
.../com/spotify/heroic/common/EmptyOptionalLimit.java 61.76% <0.00%> (-8.83%) 17.00% <0.00%> (-2.00%)
...y/heroic/metric/bigtable/BigtableMetricModule.java 79.71% <0.00%> (-6.15%) 5.00% <0.00%> (-2.00%)
...com/spotify/heroic/metric/MetricManagerModule.java 70.40% <0.00%> (-3.70%) 16.00% <0.00%> (-2.00%)
...ytics/bigtable/BigtableAnalyticsMetricBackend.java 23.80% <0.00%> (-3.47%) 2.00% <0.00%> (-1.00%)
...heroic/suggest/elasticsearch/SuggestBackendKV.java 80.16% <0.00%> (-2.09%) 61.00% <0.00%> (-16.00%)
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ab6620...6fd5708. Read the comment docs.

@sming sming self-assigned this Jul 30, 2020
@sming
Copy link
Contributor

sming commented Jul 30, 2020

LGTM. What are the throws Exception moves about - just fixing compiler warnings?

@lmuhlha
Copy link
Member Author

lmuhlha commented Aug 3, 2020

LGTM. What are the throws Exception moves about - just fixing compiler warnings?

Yes indeed :)

Going to add some more changes to this PR after I continue troubleshooting.

@sming sming removed their assignment Feb 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants