Skip to content
This repository has been archived by the owner on Mar 27, 2021. It is now read-only.

adds x-client-id header to example curl in docco #766

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sming
Copy link
Contributor

@sming sming commented Mar 24, 2021

@project-bot project-bot bot added this to In progress in Observability Kanban Mar 24, 2021
@sming sming moved this from In progress to Waiting for review in Observability Kanban Mar 24, 2021
@codecov
Copy link

codecov bot commented Mar 24, 2021

Codecov Report

Merging #766 (82b6e32) into master (c6b5a6f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #766   +/-   ##
=========================================
  Coverage     55.21%   55.21%           
  Complexity     3176     3176           
=========================================
  Files           751      751           
  Lines         20544    20544           
  Branches       1343     1343           
=========================================
  Hits          11343    11343           
  Misses         8715     8715           
  Partials        486      486           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6b5a6f...82b6e32. Read the comment docs.

@@ -48,7 +48,7 @@ <h4>Example Curl</h4>
{%
endunless %}
{%- endcapture %}
$ curl -X{{ page.method }} {{ headers -}}
$ curl {{ page.x-client-id-header }} -X{{ page.method }} {{ headers -}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does {{ headers -}} not imply all headers here anyway?

@lmuhlha lmuhlha removed this from Waiting for review in Observability Kanban Mar 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add x-client-id to markdown documentation examples for /query/[metrics|batch]
2 participants