Skip to content
This repository has been archived by the owner on Mar 27, 2021. It is now read-only.

add x-client-id to markdown documentation examples for /query/[metrics|batch] #754

Open
sming opened this issue Feb 4, 2021 · 0 comments · May be fixed by #766
Open

add x-client-id to markdown documentation examples for /query/[metrics|batch] #754

sming opened this issue Feb 4, 2021 · 0 comments · May be fixed by #766
Assignees

Comments

@sming
Copy link
Contributor

sming commented Feb 4, 2021

basically need to find a neat way of adding "x-client-id: my-app" to the example cURLs given in https://spotify.github.io/heroic/docs/api/post-query-metrics and https://spotify.github.io/heroic/docs/api/post-query-batch .

it's not that easy since we want this only to be added to these two endpoints. Probably need to create a "sub class" of whatever spits out the curl -XPOST ... text.

@sming sming created this issue from a note in Observability Kanban (Inbox) Feb 4, 2021
@lmuhlha lmuhlha moved this from Inbox to To do in Observability Kanban Feb 22, 2021
@sming sming linked a pull request Mar 24, 2021 that will close this issue
@sming sming self-assigned this Mar 24, 2021
@project-bot project-bot bot moved this from To do to In progress in Observability Kanban Mar 24, 2021
@sming sming moved this from In progress to Waiting for review in Observability Kanban Mar 24, 2021
@sming sming linked a pull request Mar 24, 2021 that will close this issue
@lmuhlha lmuhlha removed this from Waiting for review in Observability Kanban Mar 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant