Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow EffectRouter to be passed to Mobius.loop directly #116

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

JensAyton
Copy link
Contributor

Alternative to #114 .

The downside of this approach is that there are now four overloads of Mobius.loop, which could get nasty if we want to add more dimensions of variants, or just change the interface (for instance, using defaulted arguments instead of the three remaining with functions).

I prefer this approach if we view the explicit Connectable approach as transitional. If we want to keep all the variants forever, I lean towards #114 .

@jeppes @rastersize

@jeppes
Copy link
Contributor

jeppes commented Feb 18, 2020

Hmm, I'm not sure about this. I think there are good arguments for both.
Any thoughts, @pettermahlen?

@codecov
Copy link

codecov bot commented Mar 10, 2020

Codecov Report

Merging #116 into master will decrease coverage by 0.26%.
The diff coverage is 70.58%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #116      +/-   ##
==========================================
- Coverage    92.3%   92.03%   -0.27%     
==========================================
  Files          46       46              
  Lines        1442     1456      +14     
==========================================
+ Hits         1331     1340       +9     
- Misses        111      116       +5
Flag Coverage Δ
#ios 92.03% <70.58%> (-0.27%) ⬇️
#macspm 92.03% <70.58%> (-0.27%) ⬇️
Impacted Files Coverage Δ
MobiusCore/Source/Mobius.swift 88.67% <70.58%> (-3.72%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a68b568...ccf05d0. Read the comment docs.

@rastersize
Copy link
Contributor

I missed reviewing this one I think. I’m personally in favor of this approach and eventually removing the Connectable variant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants