Skip to content

Commit

Permalink
IOS-1346: Xcode 11 support and SPM file reorganization (#18)
Browse files Browse the repository at this point in the history
  • Loading branch information
bdrelling committed Oct 8, 2019
1 parent 2e032b7 commit ebcc8db
Show file tree
Hide file tree
Showing 56 changed files with 1,982 additions and 992 deletions.
7 changes: 7 additions & 0 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
# Lines starting with '#' are comments.
# Each line is a file pattern followed by one or more owners.
# Source: https://blog.github.com/2017-07-06-introducing-code-owners/
# Source: https://help.github.com/articles/about-codeowners/

# These owners will be the default owners for everything in the repo.
* @spothero/ios
5 changes: 5 additions & 0 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
**Issue Link**
<!-- Link to the Jira ticket or GitHub issue -->

**Description**
<!-- Describe what items this PR changes. -->
82 changes: 74 additions & 8 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,6 +1,15 @@
# Xcode
#
# gitignore contributors: remember to update Global/Xcode.gitignore, Objective-C.gitignore & Swift.gitignore

## Exclude OS X folder attributes
.DS_Store
*/build/*

## Build generated
build/
DerivedData/

## Various settings
*.pbxuser
!default.pbxuser
*.mode1v3
Expand All @@ -9,13 +18,70 @@
!default.mode2v3
*.perspectivev3
!default.perspectivev3
xcuserdata
profile
xcuserdata/

## Other
*.moved-aside
DerivedData
.idea/
*.hmap
*.xccheckout
*.xcscmblueprint

## Obj-C/Swift specific
*.hmap
*.ipa
*.dSYM.zip
*.dSYM

## Playgrounds
timeline.xctimeline
playground.xcworkspace

# Swift Package Manager
#
# Add this line if you want to avoid checking in source code from Swift Package Manager dependencies.
# Packages/
# Package.pins
.build/

# .swiftpm/ is generated when editing a Swift package in Xcode 11
.swiftpm/

# For SPM-only projects, .xcworkspace or .xcodeproj files should never be created or generated, except for use with versions earlier than Xcode 11
# *.xcworkspace
# *.xcodeproj

# CocoaPods
#
# We recommend against adding the Pods directory to your .gitignore. However
# you should judge for yourself, the pros and cons are mentioned at:
# https://guides.cocoapods.org/using/using-cocoapods.html#should-i-check-the-pods-directory-into-source-control
#
# Pods/

# Carthage
#
# Add this line if you want to avoid checking in source code from Carthage dependencies.
# Carthage/Checkouts
Carthage/Build

# jazzy
undocumented.json
*.tgz

# fastlane
#
# It is recommended to not store the screenshots in the git repo. Instead, use fastlane to re-generate the
# screenshots whenever they are needed.
# For more information about the recommended setup visit:
# https://docs.fastlane.tools/best-practices/source-control/#source-control

fastlane/test_output
fastlane/[Pp]rovisioning
fastlane/report.xml
fastlane/[Bb]uild
fastlane/DerivedData
fastlane/screenshots
fastlane/[Pp]review.html

#CocoaPods
Pods
# dotenv
# A .env.local file contains keys that should never be checked into the repository
.env.local
22 changes: 22 additions & 0 deletions Config/SpotHeroEmailValidator-Info.plist
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
<key>CFBundleDevelopmentRegion</key>
<string>$(DEVELOPMENT_LANGUAGE)</string>
<key>CFBundleExecutable</key>
<string>$(EXECUTABLE_NAME)</string>
<key>CFBundleIdentifier</key>
<string>$(PRODUCT_BUNDLE_IDENTIFIER)</string>
<key>CFBundleInfoDictionaryVersion</key>
<string>6.0</string>
<key>CFBundleName</key>
<string>$(PRODUCT_NAME)</string>
<key>CFBundlePackageType</key>
<string>$(PRODUCT_BUNDLE_PACKAGE_TYPE)</string>
<key>CFBundleShortVersionString</key>
<string>1.0</string>
<key>CFBundleVersion</key>
<string>$(CURRENT_PROJECT_VERSION)</string>
</dict>
</plist>
Original file line number Diff line number Diff line change
Expand Up @@ -3,19 +3,19 @@
<plist version="1.0">
<dict>
<key>CFBundleDevelopmentRegion</key>
<string>en</string>
<string>$(DEVELOPMENT_LANGUAGE)</string>
<key>CFBundleExecutable</key>
<string>${EXECUTABLE_NAME}</string>
<string>$(EXECUTABLE_NAME)</string>
<key>CFBundleIdentifier</key>
<string>$(PRODUCT_BUNDLE_IDENTIFIER)</string>
<key>CFBundleInfoDictionaryVersion</key>
<string>6.0</string>
<key>CFBundleName</key>
<string>$(PRODUCT_NAME)</string>
<key>CFBundlePackageType</key>
<string>BNDL</string>
<string>$(PRODUCT_BUNDLE_PACKAGE_TYPE)</string>
<key>CFBundleShortVersionString</key>
<string>1.0</string>
<key>CFBundleSignature</key>
<string>????</string>
<key>CFBundleVersion</key>
<string>1</string>
</dict>
Expand Down
530 changes: 0 additions & 530 deletions Demo+Tests/EmailValidatorDemo.xcodeproj/project.pbxproj

This file was deleted.

This file was deleted.

61 changes: 0 additions & 61 deletions Demo+Tests/EmailValidatorDemo/AppDelegate.m

This file was deleted.

16 changes: 0 additions & 16 deletions Demo+Tests/EmailValidatorDemo/EmailValidatorDemo-Prefix.pch

This file was deleted.

This file was deleted.

This file was deleted.

2 changes: 0 additions & 2 deletions Demo+Tests/EmailValidatorDemo/en.lproj/InfoPlist.strings

This file was deleted.

19 changes: 0 additions & 19 deletions Demo+Tests/SHEmailValidatorTests/LevenshteinDistanceTestModel.h

This file was deleted.

23 changes: 0 additions & 23 deletions Demo+Tests/SHEmailValidatorTests/LevenshteinDistanceTestModel.m

This file was deleted.

20 changes: 0 additions & 20 deletions Demo+Tests/SHEmailValidatorTests/ValidatorTestModel.h

This file was deleted.

31 changes: 0 additions & 31 deletions Demo+Tests/SHEmailValidatorTests/ValidatorTestModel.m

This file was deleted.

2 changes: 0 additions & 2 deletions Demo+Tests/SHEmailValidatorTests/en.lproj/InfoPlist.strings

This file was deleted.

0 comments on commit ebcc8db

Please sign in to comment.