Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable override defaults for redis images #668

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

romanfurst
Copy link

Current implementation

since default Redis images are hardcoded, updating redis-operator version might cause all incances of redisdailover cluster are restarted if hardcoded default values has changed. It might be undesirable behavior especially in production environment (assume deploy with gitops argocd)



Propose implementation

default images are externally configurable. You can change redis-operator version but your defined default versions of redisfailover instances stay still -> redisfailover instances not change -> no restart

@romanfurst romanfurst requested a review from a team as a code owner October 6, 2023 17:51
@romanfurst romanfurst changed the title enable ovveride defaults for redis images enable override defaults for redis images Oct 6, 2023
@SISheogorath
Copy link

SISheogorath commented Oct 16, 2023

Personal opinion: I would love to see a Full Qualified Image Name(FQIN, docker.io/library/redis:6.2.6-alpine instead of redis:6.2.6-alpine) since all main kubernetes runtimes (containerd, cri-o, …) allow to override mirroring of registries already, there is no benefit of not using a FQIN.

Some container runtimes can be configured to refuse to start when the image name is not a FQIN, e.g. cri-o with strict configuration. Further it helps to make clear what redis image is actually intended to be used and not just some image that happens to have these tags causing unexpected issues due to different resolution of image names/tags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants