Feat/hash annotations #583
Open
+205
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@raghu-nandan-bs Thanks! Is there an image available in the registry for this branch which we can use? |
Hi @avthart we can build an image using |
|
@raghu-nandan-bs Would be great if you can provide an |
|
@avthart please try with |
|
This looks good:
Also see Kyverno logs: Created a new RedisFailover: Only the statefulset is updated every 30 seconds: |
|
Any update on this one? |
|
Hi @avthart sorry, I'll pick this up and close in few days. |
|
That would be great! |
@avthart could you please try running with image: please add following under spec.template.spec.containers[0] for redis operator deployment I've updated the code and ran some basic tests. Once you can confirm that this works as expected, I'll add some test cases and finalize the PR. |
@avthart please let me know if you've tried the new image and if it works as expected.. |
|
Operator running with your version: Operators logs confirm that resources are up to date: Checking version of the resources self: Normally, this counter increases with every reconciliation of the operator. This looks good! Questions:
Thanks! |
|
@avthart thanks a lot for confirming, I'll proceed with writing test cases and submit the PR formally.
Since this is a new feature, would like to keep it in "beta" state and not break existing functionality. Any user who wants to use this optimization can opt-in with the flag. Once the feature is generally accepted, we can make it a default. @samof76 @dinesh-murugiah @ese please pitch in if there's any contrary opinion.
I hope so, depends on the repo's owners 😬 |
raghu-nandan-bs
commented
Nov 14, 2023
| // Set the correct resource version to ensure we are on the latest version. This way the only valid | ||
| // namespace is our spec(https://github.com/kubernetes/community/blob/master/contributors/devel/api-conventions.md#concurrency-control-and-consistency), | ||
| // we will replace the current namespace state. | ||
| statefulSet.ResourceVersion = storedStatefulSet.ResourceVersion |
There was a problem hiding this comment.
resource version always changes after apply, causing sts to have perpetual diff
raghu-nandan-bs
force-pushed
the
feat/hash-annotations
branch
from
bbf6f34
to
700e8bd
Compare
|
Any update @raghu-nandan-bs @ese @samof76? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #580
Changes proposed on the PR:
CreateOrUpdate, apply the changes only if there is a diff in hash.