Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add opportunity skip kenpom tests #122

Merged
merged 3 commits into from Aug 24, 2023
Merged

add opportunity skip kenpom tests #122

merged 3 commits into from Aug 24, 2023

Conversation

shufinskiy
Copy link
Contributor

@saiemgilani hello.

I suggest adding the ability to skip testing KenPom site functions for those developers who do not have an account on it. Due to the fact that these tests fail with an error, I can't get to testing the functions of the site NBA.com, because testing ends due to exceeding the error limit. My fix will allow those who do not have an account on KenPom to skip these tests.

@vercel
Copy link

vercel bot commented Aug 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hoopr ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 24, 2023 2:10pm

@shufinskiy shufinskiy merged commit c43c6b7 into sportsdataverse:main Aug 24, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants