Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved functions that have 2001 data to accepting 2001 as a valid year #114

Merged
merged 1 commit into from May 1, 2023

Conversation

andreweatherman
Copy link
Member

KenPom recently published 2001 data to select endpoints on his site. On functions servicing that data, I have allowed 2001 to be an accepted year:

if (!(is.numeric(min_year) && nchar(min_year) == 4 && 
            min_year >= **2001**)) {
            cli::cli_abort("Enter valid min_ as a number (YYYY), data only goes back to **2001**")
        }

@vercel
Copy link

vercel bot commented Apr 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hoopr ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 28, 2023 5:56am

@saiemgilani
Copy link
Collaborator

Andrew, you're a member of the sportsdataverse... why did you fork and PR, but okay, this presumably works. I'll review/make any edits and merge

@saiemgilani saiemgilani merged commit 8726723 into sportsdataverse:main May 1, 2023
1 of 4 checks passed
@saiemgilani saiemgilani self-requested a review May 1, 2023 00:57
Copy link
Collaborator

@saiemgilani saiemgilani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants