Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NBA Live & Docs #108

Merged
merged 6 commits into from Mar 24, 2023
Merged

NBA Live & Docs #108

merged 6 commits into from Mar 24, 2023

Conversation

saiemgilani
Copy link
Collaborator

Primarily concerns upgrades to the NBA Stats API functions under the hood for parsing/DRY

New Functions

  • nba_shotchartlineupdetail() function added.
  • nba_synergyplaytypes() function added.
  • nba_live_pbp() function added.
  • nba_live_boxscore() function added.
  • nba_franchiseleaderswrank() function added.
  • nba_videodetailsasset() function added.

Documentation Updates

Adding details examples with links to which part of the NBA front-end it corresponds to for easier future reference.

#' @details
#' [Synergy Play Type Stats](https://www.nba.com/stats/teams/isolation)
#' ```r
#'  nba_synergyplaytypes(league_id = '00', season = year_to_season(most_recent_nba_season() - 1))
#' ```

image

Updated Rd names to function names (i.e. pbp to nba_pbp)

@vercel
Copy link

vercel bot commented Mar 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
hoopr ✅ Ready (Inspect) Visit Preview Mar 24, 2023 at 4:05AM (UTC)

@andreweatherman andreweatherman merged commit f18e789 into main Mar 24, 2023
4 checks passed
@saiemgilani saiemgilani deleted the devel branch March 24, 2023 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants