Coordinate adjustments #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gin of coordinate system to center court
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
FWIW the only tests that are failing locally are the Kenpom functions |
…re a shot chart is not available
… throw locations; using coordinate_[x, y]_raw to indicate from-the-API coordinates and coordinate_[x, y] to represent transformed/aligned coordinates
|
Made some updates to comply with tidyselect updates for the dplyr::rename portion of your coordinate alignment |
saiemgilani
approved these changes
Mar 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed while debugging this issue that the ESPN coordinates that come from the API don't align with how the shot chart displays on the ESPN page. This PR transforms the coordinate system to the following:
(0, 0)+x), with y coordinates flipped to mirror the image on the ESPN pageLet me know what (if anything) needs to be adjusted here