Skip to content

Commit

Permalink
options (#39)
Browse files Browse the repository at this point in the history
* options config change
  • Loading branch information
saiemgilani committed Oct 27, 2021
1 parent c88939e commit f30b679
Show file tree
Hide file tree
Showing 7 changed files with 31 additions and 27 deletions.
2 changes: 1 addition & 1 deletion DESCRIPTION
@@ -1,6 +1,6 @@
Package: hoopR
Title: Functions to Access Men's Basketball Play by Play Data
Version: 1.4.2
Version: 1.4.3
Authors@R:
c(person(given = "Saiem",
family = "Gilani",
Expand Down
1 change: 0 additions & 1 deletion NAMESPACE
Expand Up @@ -195,7 +195,6 @@ export(nba_videostatus)
export(nba_winprobabilitypbp)
export(ncaa_mbb_NET_rankings)
export(progressively)
export(rejoin_schedules)
export(update_mbb_db)
export(update_nba_db)
export(year_to_season)
Expand Down
3 changes: 3 additions & 0 deletions NEWS.md
@@ -1,3 +1,6 @@
# **hoopR 1.4.3**
- Option configs changed to revert to user options

# **hoopR 1.4.2**
- Implement additional boxscore function parameters for ```nba_boxscore(.*)``` functions

Expand Down
28 changes: 14 additions & 14 deletions R/espn_mbb_data.R
Expand Up @@ -14,8 +14,8 @@
#'

espn_mbb_game_all <- function(game_id){
options(stringsAsFactors = FALSE)
options(scipen = 999)
old <- options(list(stringsAsFactors = FALSE, scipen = 999))
on.exit(options(old))

play_base_url <- "http://cdn.espn.com/mens-college-basketball/playbyplay?render=false&userab=1&xhr=1&"

Expand Down Expand Up @@ -196,8 +196,8 @@ espn_mbb_game_all <- function(game_id){
#' espn_mbb_pbp(game_id = 401256760)
#'
espn_mbb_pbp <- function(game_id){
options(stringsAsFactors = FALSE)
options(scipen = 999)
old <- options(list(stringsAsFactors = FALSE, scipen = 999))
on.exit(options(old))

play_base_url <- "http://cdn.espn.com/mens-college-basketball/playbyplay?render=false&userab=1&xhr=1&"

Expand Down Expand Up @@ -259,8 +259,8 @@ espn_mbb_pbp <- function(game_id){
#' espn_mbb_team_box(game_id = 401256760)
#'
espn_mbb_team_box <- function(game_id){
options(stringsAsFactors = FALSE)
options(scipen = 999)
old <- options(list(stringsAsFactors = FALSE, scipen = 999))
on.exit(options(old))
play_base_url <- "http://cdn.espn.com/mens-college-basketball/playbyplay?render=false&userab=1&xhr=1&"

## Inputs
Expand Down Expand Up @@ -365,8 +365,8 @@ espn_mbb_team_box <- function(game_id){
#' espn_mbb_player_box(game_id = 401256760)
#'
espn_mbb_player_box <- function(game_id){
options(stringsAsFactors = FALSE)
options(scipen = 999)
old <- options(list(stringsAsFactors = FALSE, scipen = 999))
on.exit(options(old))
play_base_url <- "http://cdn.espn.com/mens-college-basketball/playbyplay?render=false&userab=1&xhr=1&"

## Inputs
Expand Down Expand Up @@ -444,8 +444,8 @@ espn_mbb_player_box <- function(game_id){
#' espn_mbb_conferences()
#'
espn_mbb_conferences <- function(){
options(stringsAsFactors = FALSE)
options(scipen = 999)
old <- options(list(stringsAsFactors = FALSE, scipen = 999))
on.exit(options(old))
play_base_url <- "http://site.api.espn.com/apis/site/v2/sports/basketball/mens-college-basketball/scoreboard/conferences"

res <- httr::RETRY("GET", play_base_url)
Expand Down Expand Up @@ -487,8 +487,8 @@ espn_mbb_conferences <- function(){
#' espn_mbb_teams()
#'
espn_mbb_teams <- function(){
options(stringsAsFactors = FALSE)
options(scipen = 999)
old <- options(list(stringsAsFactors = FALSE, scipen = 999))
on.exit(options(old))
play_base_url <- "http://site.api.espn.com/apis/site/v2/sports/basketball/mens-college-basketball/teams?groups=50&limit=1000"

res <- httr::RETRY("GET", play_base_url)
Expand Down Expand Up @@ -758,8 +758,8 @@ ncaa_mbb_NET_rankings <- function(){
#' espn_mbb_rankings()

espn_mbb_rankings <- function(){
options(stringsAsFactors = FALSE)
options(scipen = 999)
old <- options(list(stringsAsFactors = FALSE, scipen = 999))
on.exit(options(old))

ranks_url <- "http://site.api.espn.com/apis/site/v2/sports/basketball/mens-college-basketball/rankings?groups=50"

Expand Down
20 changes: 10 additions & 10 deletions R/espn_nba_data.R
Expand Up @@ -14,8 +14,8 @@
#'

espn_nba_game_all <- function(game_id){
options(stringsAsFactors = FALSE)
options(scipen = 999)
old <- options(list(stringsAsFactors = FALSE, scipen = 999))
on.exit(options(old))

play_base_url <- "http://cdn.espn.com/core/nba/playbyplay?render=false&userab=1&xhr=1&"

Expand Down Expand Up @@ -193,8 +193,8 @@ espn_nba_game_all <- function(game_id){
#' espn_nba_pbp(game_id = 401283399)
#'
espn_nba_pbp <- function(game_id){
options(stringsAsFactors = FALSE)
options(scipen = 999)
old <- options(list(stringsAsFactors = FALSE, scipen = 999))
on.exit(options(old))

play_base_url <- "http://cdn.espn.com/core/nba/playbyplay?render=false&userab=1&xhr=1&"

Expand Down Expand Up @@ -259,8 +259,8 @@ espn_nba_pbp <- function(game_id){
#' espn_nba_team_box(game_id = 401283399)
#'
espn_nba_team_box <- function(game_id){
options(stringsAsFactors = FALSE)
options(scipen = 999)
old <- options(list(stringsAsFactors = FALSE, scipen = 999))
on.exit(options(old))
play_base_url <- "http://cdn.espn.com/core/nba/playbyplay?render=false&userab=1&xhr=1&"

## Inputs
Expand Down Expand Up @@ -363,8 +363,8 @@ espn_nba_team_box <- function(game_id){
#' espn_nba_player_box(game_id = 401283399)
#'
espn_nba_player_box <- function(game_id){
options(stringsAsFactors = FALSE)
options(scipen = 999)
old <- options(list(stringsAsFactors = FALSE, scipen = 999))
on.exit(options(old))
play_base_url <- "http://cdn.espn.com/core/nba/playbyplay?render=false&userab=1&xhr=1&"

## Inputs
Expand Down Expand Up @@ -443,8 +443,8 @@ espn_nba_player_box <- function(game_id){
#'

espn_nba_teams <- function(){
options(stringsAsFactors = FALSE)
options(scipen = 999)
old <- options(list(stringsAsFactors = FALSE, scipen = 999))
on.exit(options(old))
play_base_url <- "http://site.api.espn.com/apis/site/v2/sports/basketball/nba/teams?limit=1000"


Expand Down
1 change: 0 additions & 1 deletion R/utils_nba_stats.R
Expand Up @@ -202,7 +202,6 @@ year_to_season <- function(year){
#' @importFrom dplyr mutate filter select left_join
#' @importFrom stringr str_detect
#' @importFrom tidyr everything
#' @export
rejoin_schedules <- function(df){
df <- df %>%
dplyr::mutate(
Expand Down
3 changes: 3 additions & 0 deletions docs/src/pages/CHANGELOG.md
@@ -1,3 +1,6 @@
# **hoopR 1.4.3**
- Option configs changed to revert to user options

# **hoopR 1.4.2**
- Implement additional boxscore function parameters for ```nba_boxscore(.*)``` functions

Expand Down

1 comment on commit f30b679

@vercel
Copy link

@vercel vercel bot commented on f30b679 Oct 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.