update tests

sportsdataverse · Apr 10, 2023 · 8ccc33b · 8ccc33b
1 parent 447c35b
commit 8ccc33b
Show file tree

Hide file tree

Showing 9 changed files with 1,836 additions and 355 deletions.
diff --git a/R/nba_stats_scoreboard.R b/R/nba_stats_scoreboard.R
@@ -839,7 +839,7 @@ nba_todays_scoreboard <- function(
 
     },
     error = function(e) {
-      message(glue::glue("{Sys.time()}: Invalid arguments or no today's scoreboard data for {game_date} available!"))
+      message(glue::glue("{Sys.time()}: Invalid arguments or no today's scoreboard data available!"))
     },
     warning = function(w) {
     },

diff --git a/data-raw/dict_hoopR.csv b/data-raw/dict_hoopR.csv
diff --git a/data-raw/dict_test.csv b/data-raw/dict_test.csv
diff --git a/data-raw/espn_mbb_teams.csv b/data-raw/espn_mbb_teams.csv
diff --git a/data-raw/kp_team_info.csv b/data-raw/kp_team_info.csv
diff --git a/data-raw/kp_team_info_2023.csv b/data-raw/kp_team_info_2023.csv
diff --git a/data-raw/pull_team_links.R b/data-raw/pull_team_links.R
@@ -1,10 +1,21 @@
-library(rvest)
-library(dplyr)
-Years = 2023:2002
-browser <- login(Sys.getenv("kp_user"),Sys.getenv("kp_pw"))
+suppressPackageStartupMessages(suppressMessages(library(rvest)))
+suppressPackageStartupMessages(suppressMessages(library(dplyr)))
+suppressPackageStartupMessages(suppressMessages(library(tidyr)))
+suppressPackageStartupMessages(suppressMessages(library(stringr)))
+suppressPackageStartupMessages(suppressMessages(library(magrittr)))
+suppressPackageStartupMessages(suppressMessages(library(jsonlite)))
+suppressPackageStartupMessages(suppressMessages(library(purrr)))
+suppressPackageStartupMessages(suppressMessages(library(progressr)))
+suppressPackageStartupMessages(suppressMessages(library(data.table)))
+suppressPackageStartupMessages(suppressMessages(library(arrow)))
+suppressPackageStartupMessages(suppressMessages(library(glue)))
+suppressPackageStartupMessages(suppressMessages(library(optparse)))
+years <- hoopR::most_recent_mbb_season()
+
+browser <- hoopR::login()
 
 all_teams_links <- data.frame()
-for (year in Years) {
+for (year in years) {
   url <- paste0("https://kenpom.com/index.php?y=", year)
   page <- rvest::session_jump_to(browser, url)
   q <- (page %>%
@@ -45,7 +56,6 @@ for (year in Years) {
 
   nrow(team_links)
 
-  library(stringr)
   team_links <- team_links %>%
     dplyr::mutate(
       team.link.ref = stringr::str_remove(stringr::str_extract(string = .data$Team.link,"=(.+)"),"=|&y(.+)"),
@@ -59,24 +69,30 @@ for (year in Years) {
       "conf.link.ref") %>%
     dplyr::mutate(Year = year)
   all_teams_links <- dplyr::bind_rows(all_teams_links,team_links)
-
+  Sys.sleep(5)
 }
 all_teams <- collapse::funique.data.frame(all_teams_links)
 
-write.csv(all_teams, "data-raw/kp_team_info.csv", row.names = FALSE)
-teams_links <- all_teams
-usethis::use_data(teams_links, overwrite = TRUE)
-
-
-teamlist <- data.frame(hoopR::teams_links)
-
-
-teamlist
-
-
-
-
-
-
-
-
+write.csv(all_teams, "data-raw/kp_team_info_2023.csv", row.names = FALSE)
+# remotes::install_github("lbenz730/ncaahoopR")
+all_teams_joined <- all_teams %>%
+  dplyr::left_join(ncaahoopR::dict, by = c("Team" = "Trank"), keep = TRUE) %>%
+  dplyr::filter(!is.na(.data$Trank))
+
+anti_joined_all_teams <- all_teams %>%
+  dplyr::anti_join(ncaahoopR::dict, by = c("Team" = "Trank"))
+
+dict_hoopR <- data.table::fread("data-raw/dict_hoopR.csv")
+espn_teams <- espn_mbb_teams()
+ncaa_teams <- ncaa_mbb_teams(year = hoopR::most_recent_mbb_season(), division = 1)
+
+dict_hoopR_joined <- dict_hoopR %>%
+  dplyr::left_join(espn_teams, by = c("ESPN" = "team"), keep = TRUE) %>%
+  dplyr::left_join(espn_teams, by = c("ESPN_PBP" = "team"))
+
+# teams_links <- all_teams
+# usethis::use_data(teams_links, overwrite = TRUE)
+#
+# teamlist <- data.frame(hoopR::teams_links)
+#
+# teamlist
diff --git a/tests/testthat/test-load_mbb_schedule.R b/tests/testthat/test-load_mbb_schedule.R
@@ -73,11 +73,13 @@ test_that("hoopR Loader MBB Schedule", {
     "groups_short_name",
     "groups_is_conference",
     "tournament_id",
+    "game_json",
+    "game_json_url",
+    "game_date_time",
+    "game_date",
     "PBP",
     "team_box",
-    "player_box",
-    "game_date",
-    "game_date_time"
+    "player_box"
   )
 
   expect_equal(sort(colnames(x)), sort(cols))

diff --git a/tests/testthat/test-load_nba_schedule.R b/tests/testthat/test-load_nba_schedule.R
@@ -66,11 +66,13 @@ test_that("hoopR Loader NBA Schedule", {
     "season_type",
     "venue_address_state",
     "status_type_alt_detail",
+    "game_json",
+    "game_json_url",
+    "game_date_time",
+    "game_date",
     "PBP",
     "team_box",
-    "player_box",
-    "game_date_time",
-    "game_date"
+    "player_box"
   )
 
   expect_equal(sort(colnames(x)), sort(cols))