Skip to content

Commit

Permalink
Implement additional nba_boxscore(.*) parameters (#38)
Browse files Browse the repository at this point in the history
* implement additional boxscore function parameters
  • Loading branch information
saiemgilani committed Oct 27, 2021
1 parent 386c23d commit 7e0ae03
Show file tree
Hide file tree
Showing 9 changed files with 215 additions and 43 deletions.
2 changes: 1 addition & 1 deletion DESCRIPTION
@@ -1,6 +1,6 @@
Package: hoopR
Title: Functions to Access Men's Basketball Play by Play Data
Version: 1.4.1
Version: 1.4.2
Authors@R:
c(person(given = "Saiem",
family = "Gilani",
Expand Down
3 changes: 3 additions & 0 deletions NEWS.md
@@ -1,3 +1,6 @@
# **hoopR 1.4.2**
- Implement additional boxscore function parameters for ```nba_boxscore(.*)``` functions

# **hoopR 1.4.1**
- Update ```teams_links``` internal dataset for 2022 (need a better solve here)
- Added ```nba_teams``` dataset for working with the NBA Stats API
Expand Down
139 changes: 103 additions & 36 deletions R/nba_stats_boxscore.R
Expand Up @@ -7,23 +7,34 @@ NULL
#' @rdname bs_tradv2
#' @author Saiem Gilani
#' @param game_id Game ID
#' @param start_period start_period
#' @param end_period end_period
#' @param start_range start_range
#' @param end_range end_range
#' @param range_type range_type
#' @importFrom jsonlite fromJSON toJSON
#' @importFrom dplyr filter select rename bind_cols bind_rows
#' @importFrom tidyr unnest unnest_wider everything
#' @import rvest
#' @export
nba_boxscoretraditionalv2 <- function(game_id){
nba_boxscoretraditionalv2 <- function(
game_id,
start_period=0,
end_period=14,
start_range=0,
end_range=0,
range_type=0){

version <- "boxscoretraditionalv2"
endpoint <- nba_endpoint(version)

full_url <- paste0(endpoint,
"?EndPeriod=0",
"&EndRange=0",
"?EndPeriod=", end_period,
"&EndRange=", end_range,
"&GameID=",pad_id(game_id),
"&RangeType=0",
"&StartPeriod=0",
"&StartRange=0")
"&RangeType=", range_type,
"&StartPeriod=",start_period,
"&StartRange=", start_range)
tryCatch(
expr={
resp <- full_url %>%
Expand Down Expand Up @@ -59,23 +70,35 @@ NULL
#' @rdname bs_advv2
#' @author Saiem Gilani
#' @param game_id Game ID
#' @param start_period start_period
#' @param end_period end_period
#' @param start_range start_range
#' @param end_range end_range
#' @param range_type range_type
#' @importFrom jsonlite fromJSON toJSON
#' @importFrom dplyr filter select rename bind_cols bind_rows
#' @importFrom tidyr unnest unnest_wider everything
#' @import rvest
#' @export
nba_boxscoreadvancedv2 <- function(game_id){
nba_boxscoreadvancedv2 <- function(
game_id,
start_period=0,
end_period=14,
start_range=0,
end_range=0,
range_type=0){

version <- "boxscoreadvancedv2"
endpoint <- nba_endpoint(version)


full_url <- paste0(endpoint,
"?EndPeriod=0",
"&EndRange=0",
"?EndPeriod=", end_period,
"&EndRange=", end_range,
"&GameID=",pad_id(game_id),
"&RangeType=0",
"&StartPeriod=0",
"&StartRange=0")
"&RangeType=", range_type,
"&StartPeriod=",start_period,
"&StartRange=", start_range)

tryCatch(
expr={
Expand Down Expand Up @@ -160,23 +183,34 @@ NULL
#' @rdname bs_ffv2
#' @author Saiem Gilani
#' @param game_id Game ID
#' @param start_period start_period
#' @param end_period end_period
#' @param start_range start_range
#' @param end_range end_range
#' @param range_type range_type
#' @importFrom jsonlite fromJSON toJSON
#' @importFrom dplyr filter select rename bind_cols bind_rows
#' @importFrom tidyr unnest unnest_wider everything
#' @import rvest
#' @export
nba_boxscorefourfactorsv2 <- function(game_id){
nba_boxscorefourfactorsv2 <- function(
game_id,
start_period=0,
end_period=14,
start_range=0,
end_range=0,
range_type=0){

version <- "boxscorefourfactorsv2"
endpoint <- nba_endpoint(version)

full_url <- paste0(endpoint,
"?EndPeriod=0",
"&EndRange=0",
"?EndPeriod=", end_period,
"&EndRange=", end_range,
"&GameID=",pad_id(game_id),
"&RangeType=0",
"&StartPeriod=0",
"&StartRange=0")
"&RangeType=", range_type,
"&StartPeriod=",start_period,
"&StartRange=", start_range)
tryCatch(
expr={
resp <- full_url %>%
Expand Down Expand Up @@ -212,23 +246,34 @@ NULL
#' @rdname bs_miscv2
#' @author Saiem Gilani
#' @param game_id Game ID
#' @param start_period start_period
#' @param end_period end_period
#' @param start_range start_range
#' @param end_range end_range
#' @param range_type range_type
#' @importFrom jsonlite fromJSON toJSON
#' @importFrom dplyr filter select rename bind_cols bind_rows
#' @importFrom tidyr unnest unnest_wider everything
#' @import rvest
#' @export
nba_boxscoremiscv2 <- function(game_id){
nba_boxscoremiscv2 <- function(
game_id,
start_period=0,
end_period=14,
start_range=0,
end_range=0,
range_type=0){

version <- "boxscoremiscv2"
endpoint <- nba_endpoint(version)

full_url <- paste0(endpoint,
"?EndPeriod=0",
"&EndRange=0",
"?EndPeriod=", end_period,
"&EndRange=", end_range,
"&GameID=",pad_id(game_id),
"&RangeType=0",
"&StartPeriod=0",
"&StartRange=0")
"&RangeType=", range_type,
"&StartPeriod=",start_period,
"&StartRange=", start_range)
tryCatch(
expr={
resp <- full_url %>%
Expand Down Expand Up @@ -264,23 +309,34 @@ NULL
#' @rdname bs_scoringv2
#' @author Saiem Gilani
#' @param game_id Game ID
#' @param start_period start_period
#' @param end_period end_period
#' @param start_range start_range
#' @param end_range end_range
#' @param range_type range_type
#' @importFrom jsonlite fromJSON toJSON
#' @importFrom dplyr filter select rename bind_cols bind_rows
#' @importFrom tidyr unnest unnest_wider everything
#' @import rvest
#' @export
nba_boxscorescoringv2 <- function(game_id){
nba_boxscorescoringv2 <- function(
game_id,
start_period=0,
end_period=14,
start_range=0,
end_range=0,
range_type=0){

version <- "boxscorescoringv2"
endpoint <- nba_endpoint(version)

full_url <- paste0(endpoint,
"?EndPeriod=0",
"&EndRange=0",
"?EndPeriod=", end_period,
"&EndRange=", end_range,
"&GameID=",pad_id(game_id),
"&RangeType=0",
"&StartPeriod=0",
"&StartRange=0")
"&RangeType=", range_type,
"&StartPeriod=",start_period,
"&StartRange=", start_range)
tryCatch(
expr={
resp <- full_url %>%
Expand Down Expand Up @@ -316,23 +372,34 @@ NULL
#' @rdname bs_usagev2
#' @author Saiem Gilani
#' @param game_id Game ID
#' @param start_period start_period
#' @param end_period end_period
#' @param start_range start_range
#' @param end_range end_range
#' @param range_type range_type
#' @importFrom jsonlite fromJSON toJSON
#' @importFrom dplyr filter select rename bind_cols bind_rows
#' @importFrom tidyr unnest unnest_wider everything
#' @import rvest
#' @export
nba_boxscoreusagev2 <- function(game_id){
nba_boxscoreusagev2 <- function(
game_id,
start_period=0,
end_period=14,
start_range=0,
end_range=0,
range_type=0){

version <- "boxscoreusagev2"
endpoint <- nba_endpoint(version)

full_url <- paste0(endpoint,
"?EndPeriod=0",
"&EndRange=0",
"?EndPeriod=", end_period,
"&EndRange=", end_range,
"&GameID=",pad_id(game_id),
"&RangeType=0",
"&StartPeriod=0",
"&StartRange=0")
"&RangeType=", range_type,
"&StartPeriod=",start_period,
"&StartRange=", start_range)
tryCatch(
expr={
resp <- full_url %>%
Expand Down
19 changes: 18 additions & 1 deletion man/bs_advv2.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

19 changes: 18 additions & 1 deletion man/bs_ffv2.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

19 changes: 18 additions & 1 deletion man/bs_miscv2.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

19 changes: 18 additions & 1 deletion man/bs_scoringv2.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 comment on commit 7e0ae03

@vercel
Copy link

@vercel vercel bot commented on 7e0ae03 Oct 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.