Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding newline after all arguments, not after evry single argument in macros #2908

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

DipsyTipsy
Copy link

Details

Noticed that if you added more arguments to a macro, splunk would complain about the arguments being spread over several lines. Suggesting fix by having the arguments on the same line, with a newline after all the arguments.

Checklist

  • Validate name matches <platform>_<mitre att&ck technique>_<short description> nomenclature
  • CI/CD jobs passed ✔️
  • Validated SPL logic.
  • Validated tags, description, and how to implement.
  • Verified references match analytic.

@DipsyTipsy DipsyTipsy changed the title Adding newline after all arguments, not after evry single argument Adding newline after all arguments, not after evry single argument in macros Nov 1, 2023
@patel-bhavin
Copy link
Contributor

Neat PR, thanks for fixing this. We have moved our tooling that generates such file to this new repository. This new tooling is more robust and has more features to control how your yamls behave. Can you perhaps create a PR in this repository, i believe this is the file where you'd want to : https://github.com/splunk/contentctl/blob/main/contentctl/output/templates/macros.j2

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants