Skip to content
This repository has been archived by the owner on Mar 25, 2023. It is now read-only.

Commit

Permalink
Fix bug where link was not working when target page imported CSS (?!?)
Browse files Browse the repository at this point in the history
- Links on index page were mysteriously not working
- Tracked problem to the fact that target page was importing CSS
- Solution: move CSS to global import (I think this is required as of 9.3 anyway)
- Ref: vercel/next.js#5598
- Note: may cause problems linking to sphinx files (?) which still import CSS,
             but appears to work fine in docs??? what??

Makes very little sense why this fixes it, and still a bit inconsistent. Luckily
the problem seems to be related only to the dev server + HMR (??)
Check how the built version works in CI...
  • Loading branch information
milesrichardson committed May 12, 2020
1 parent 1323c08 commit 03eac2e
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
3 changes: 0 additions & 3 deletions design/Layout/BaseLayout/BaseLayout.js
@@ -1,6 +1,3 @@
import "@csstools/normalize.css";
import "../../css/base.css";

import defaultTheme from "../../themes/defaultTheme";

import { ThemeProvider } from "theme-ui";
Expand Down
3 changes: 3 additions & 0 deletions docs/pages/_app.js
@@ -1,3 +1,6 @@
import "@csstools/normalize.css";
import "@splitgraph/design/css/base.css";

import { DefaultSeo } from "next-seo";

const SEO_BASE_URL = process.env.SEO_CANONICAL_BASE_URL;
Expand Down

0 comments on commit 03eac2e

Please sign in to comment.