Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#869 Fix Invitation Mail #967

Closed

Conversation

anirudhgad
Copy link

This is my first contribution so I may have some minor errors but I think the functionality of the code should solve the Issue requested.
I used a google API call to create translation from english to any language without using manual templates by making edits to render_localized_.template function. Unfortunately the requirement of the issue to use jinja2 for automatic translation is not actually a functionality of jinja2 and will not work unless we have manual translations available which I feel defeats the purpose of the change.
Issue is that some times google translate may not be as grammatically correct as a manual translation.

@almet
Copy link
Member

almet commented Dec 16, 2021

Hi, thanks for taking the time to do this work, however, as you say the "Issue is that some times google translate may not be as grammatically correct as a manual translation".

I believe we should do a manual translation instead. You can work on this if you want, it's described in #869

@almet almet closed this Dec 16, 2021
@almet
Copy link
Member

almet commented Dec 16, 2021

Sorry, I feel this lacks some more explanations :-)

I don't think using google translation will solve this issue. We have people ready to volunteer some time in order to translate this project in different languages, so let's use this fantastic power :-)

I believe what we should do is use a trans block in the jinja template and then generate the translation files!

Let's continue the discussion in another pull-request if you still want to work on this :-)

@anirudhgad
Copy link
Author

I initially tried using the trans block in the jinja template to generate them but scrapped it because I thought the requirement was for automation I will make some changes to it and upload again!

@almet
Copy link
Member

almet commented Dec 17, 2021

Awesome, thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants