Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release documentation #893

Merged
merged 1 commit into from
Oct 30, 2021
Merged

Conversation

zorun
Copy link
Collaborator

@zorun zorun commented Oct 26, 2021

No description provided.

docs/contributing.rst Show resolved Hide resolved
docs/contributing.rst Show resolved Hide resolved
@@ -235,12 +274,22 @@ In order to issue a new release, follow the following steps:
make update-translations
make build-translations

Once this is done, let's release!::
- If you're not completely sure of yourself at this point, you
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could make this a note?


.. note:: The above command will prompt for version number, handle
:file:`CHANGELOG.rst` and :file:`setup.cfg` updates, package creation,
pypi upload. It will prompt you before each step to get your consent.

Finally, create a release on Github and copy the relevant changelog extract into it.
Unfortunately, you need to manually convert links to Markdown...
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to put that here :-) If anything, we could put the pandoc command?

@Glandos
Copy link
Member

Glandos commented Oct 27, 2021

If I understood correctly, PyPI supports Markdown: https://packaging.python.org/guides/making-a-pypi-friendly-readme/#creating-a-readme-file

So… we can convert README and CHANGELOG to markdown once for all, and get rid of it.
I personally don't have an opinion on which is the best, so I'll say that going with Markdown will make every tool happy.

@almet
Copy link
Member

almet commented Oct 30, 2021

If we change to markdown I suggest that we convert all the files and do not keep rst and md.

@almet almet merged commit 6750e4f into spiral-project:master Oct 30, 2021
TomRoussel pushed a commit to TomRoussel/ihatemoney that referenced this pull request Mar 2, 2024
Co-authored-by: Baptiste Jonglez <git@bitsofnetworks.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants