Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(check-pre-condition): CheckPrecondition doesn't evaluate expressi… #4682

Merged
merged 1 commit into from
Mar 22, 2024
Merged

fix(check-pre-condition): CheckPrecondition doesn't evaluate expressi… #4682

merged 1 commit into from
Mar 22, 2024

Conversation

yashsaxena1503
Copy link
Contributor

This PR includes the changes to fix the spinnaker/spinnaker#6933

Root cause:
If pipeline created from template, CheckPrecondition doesn't evaluate expression correctly after upstream stages get restarted
Fix:
Replace precondition List with precondition Map containing stage refId and preconditions. Modify the replace condition to replace pre-condition context with corresponding preCondition stage context.

fix(check-pre-condition): CheckPrecondition doesn't evaluate expressi…
8d8d28c 
…on correctly after upstream stages get restarted
jasonmcintosh
jasonmcintosh approved these changes Mar 22, 2024
View reviewed changes
Copy link
Member

@jasonmcintosh jasonmcintosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :)

@jasonmcintosh jasonmcintosh added the ready to merge Approved and ready for merge label Mar 22, 2024
@mergify mergify bot added the auto merged Merged automatically by a bot label Mar 22, 2024
@mergify mergify bot merged commit 613427f into spinnaker:master Mar 22, 2024
4 checks passed
@shlomodaari
Copy link

@jasonmcintosh Can we backport this for 1.33, 1.32, and 1.31?

@ovidiupopa07
Copy link
Contributor

ovidiupopa07 commented Apr 30, 2024 •
edited

@Mergifyio backport release-1.33.x release-1.32.x release-1.31.x

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 30, 2024 •
edited

backport release-1.34.x release-1.33.x release-1.32.x release-1.31.x

❌ No backport have been created

  • Backport to branch release-1.34.x not needed, change already in branch release-1.34.x
  • Backport to branch `` failed

GitHub error: Branch not found

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 30, 2024 •
edited

backport release-1.33.x release-1.32.x release-1.31.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Apr 30, 2024
@yashsaxena1503 @mergify
fix(check-pre-condition): CheckPrecondition doesn't evaluate expressi…
a01eebe 
…on correctly after upstream stages get restarted (#4682)

Co-authored-by: ysaxena <ysaxena@expediagroup.com>
(cherry picked from commit 613427f)
@mergify mergify bot mentioned this pull request Apr 30, 2024
Merged
mergify bot pushed a commit that referenced this pull request Apr 30, 2024
@yashsaxena1503 @mergify
fix(check-pre-condition): CheckPrecondition doesn't evaluate expressi…
29ff053 
…on correctly after upstream stages get restarted (#4682)

Co-authored-by: ysaxena <ysaxena@expediagroup.com>
(cherry picked from commit 613427f)
@mergify mergify bot mentioned this pull request Apr 30, 2024
Merged
mergify bot pushed a commit that referenced this pull request Apr 30, 2024
@yashsaxena1503 @mergify
fix(check-pre-condition): CheckPrecondition doesn't evaluate expressi…
afd22ce 
…on correctly after upstream stages get restarted (#4682)

Co-authored-by: ysaxena <ysaxena@expediagroup.com>
(cherry picked from commit 613427f)
@mergify mergify bot mentioned this pull request Apr 30, 2024
Merged
mergify bot added a commit that referenced this pull request May 7, 2024
@mergify @yashsaxena1503
fix(check-pre-condition): CheckPrecondition doesn't evaluate expressi…
b426314 
…on correctly after upstream stages get restarted (#4682) (#4718)

Co-authored-by: ysaxena <ysaxena@expediagroup.com>
(cherry picked from commit 613427f)

Co-authored-by: Yash Saxena <41922677+yashsaxena1503@users.noreply.github.com>
mergify bot added a commit that referenced this pull request May 7, 2024
@mergify @yashsaxena1503
fix(check-pre-condition): CheckPrecondition doesn't evaluate expressi…
25bb54c 
…on correctly after upstream stages get restarted (#4682) (#4719)

Co-authored-by: ysaxena <ysaxena@expediagroup.com>
(cherry picked from commit 613427f)

Co-authored-by: Yash Saxena <41922677+yashsaxena1503@users.noreply.github.com>
mergify bot added a commit that referenced this pull request May 7, 2024
@mergify @yashsaxena1503
fix(check-pre-condition): CheckPrecondition doesn't evaluate expressi…
da0d5ca 
…on correctly after upstream stages get restarted (#4682) (#4720)

Co-authored-by: ysaxena <ysaxena@expediagroup.com>
(cherry picked from commit 613427f)

Co-authored-by: Yash Saxena <41922677+yashsaxena1503@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonmcintosh jasonmcintosh jasonmcintosh approved these changes

Assignees
No one assigned
Labels
auto merged Merged automatically by a bot ready to merge Approved and ready for merge target-release/1.34
Projects
None yet
Milestone
No milestone
5 participants
@yashsaxena1503 @shlomodaari @ovidiupopa07 @jasonmcintosh @spinnakerbot