fix(check-pre-condition): CheckPrecondition doesn't evaluate expressi… #4681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on correctly after upstream stages get restarted
|
Please delete the pull request instructions from the body of your pull request message. The instructions start with the line:
You can reopen your pull request when this has been addressed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the changes to fix the spinnaker/spinnaker#6933
Root cause:
If pipeline created from template, CheckPrecondition doesn't evaluate expression correctly after upstream stages get restarted
Fix:
Replace preconditionList with preconditionMap containing stage refId and preconditions. Modify the replace condition to replace pre-condition context with corresponding pre-condition stage context.