fix: accept GitHub prop overrides #1994
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dbyron-sf @ovidiupopa07 @diasjorge Could I get an approval for the build workflow, and a review? |
Hi @boonware, I do not have permission to approve workflows. But I can help with the review 😃 |
|
@ovidiupopa07 Thank you, much appreciated. |
ovidiupopa07
requested changes
Dec 5, 2022
| @@ -200,4 +213,8 @@ public static Provider fromString(String name) { | |||
| + Arrays.toString(Provider.values())); | |||
| } | |||
| } | |||
|
|
|||
| private static boolean isSet(String config) { | |||
| return config != null; | |||
There was a problem hiding this comment.
maybe you can reuse a common library like the one from apache or from the SpringFramework (StringUtils)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
spinnaker/spinnaker#6766
Details
Allow GitHub auth properties to be overridden when using the
githubOAuth2 provider. This allows users to use thegithubprovider for configuring GitHub Enterprise, rather than having to use provider typeother; using provider typeotherdisables other features, see the parent issue for details.