feat(kubernetes): More configurable readiness/liveness probes #1598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds additional configuration options for liveness, and adds the same options for readiness.
Probes have the same basic options, so refactored the type to be shared for both.
Example halconfig block:
```
deploymentEnvironment:
# Numbers arbitrary
livenessProbeConfig:
enabled: true
initialDelaySeconds: 9001
timeoutSeconds: 62
periodSeconds: 60
successThreshold: 1
failureThreshold: 5
readinessProbeConfig:
enabled: true
initialDelaySeconds: 9001
timeoutSeconds: 64
periodSeconds: 61
successThreshold: 2
failureThreshold: 4
```
|
@jcavanagh apologies for the delayed response to this PR. We are actually planning on sunsetting Halyard in favor of a Kustomize-based installation path that will make it much easier to make modifications like custom readiness and liveness probes without an upstream pull request. That said, I am happy to review and merge this PR: if you are still interested in getting this merged, would you mind resolving the merge conflicts? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds additional configuration options for liveness, and adds the same options for readiness.
Probes have the same basic options, so refactored the type to be shared for both.
Example halconfig block: