refreshed spin operator readme #143
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: macolso <mackenzie.olson@fermyon.com>
macolso
requested review from
calebschoepp,
endocrimes,
bacongobbler and
michelleN
as code owners
Signed-off-by: macolso <mackenzie.olson@fermyon.com>
Closed
ThorstenHans
reviewed
Mar 8, 2024
|
|
||
| ## Contributing (Documentation) | ||
|
|
||
| If you would like to contribute to SpinKube and Spin Operator, please visit this [contributing](https://github.com/spinkube/documentation/blob/main/content/en/docs/contribution-guidelines/_index.md) page. | ||
| If you would like to contribute to SpinKube and Spin Operator, please visit this [documentation contributing](http://spinkube.dev/docs/contribution-guidelines/) page. |
There was a problem hiding this comment.
I think we should remove "documentation" from the caption of the link
endocrimes
requested changes
Mar 8, 2024
|
|
||
| ## Contributing (Documentation) | ||
|
|
||
| If you would like to contribute to SpinKube and Spin Operator, please visit this [contributing](https://github.com/spinkube/documentation/blob/main/content/en/docs/contribution-guidelines/_index.md) page. | ||
| If you would like to contribute to SpinKube and Spin Operator, please visit this [documentation contributing](http://spinkube.dev/docs/contribution-guidelines/) page. |
There was a problem hiding this comment.
Suggested change
| If you would like to contribute to SpinKube and Spin Operator, please visit this [documentation contributing](http://spinkube.dev/docs/contribution-guidelines/) page. | |
| If you would like to contribute to SpinKube and Spin Operator, please visit the [contribution guide](http://spinkube.dev/docs/contribution-guidelines/). |
Comment on lines
+3
to
+8
| kind: Kustomization | ||
| images: | ||
| - name: ghcr.io/spinkube/spin-operator | ||
| newName: ghcr.io/spinkube/spin-operator | ||
| newTag: dev |
There was a problem hiding this comment.
Suggested change
| apiVersion: kustomize.config.k8s.io/v1beta1 | |
| kind: Kustomization | |
| images: | |
| - name: ghcr.io/spinkube/spin-operator | |
| newName: ghcr.io/spinkube/spin-operator | |
| newTag: dev |
(this bit is unique to you when you make install IMG=...)
|
I think github team re-jiggling broke this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes some stale instructions and content from earlier phases of the preview
@flynnduism I can also sync with you about adding the conceptual diagram too in this PR