Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Google Custom Search for spinkube.dev #72

Merged
merged 1 commit into from Mar 11, 2024

Conversation

ThorstenHans
Copy link
Contributor

An instance of Google Custom Search (GCS) has been added and configured to index contents from .spinkube.dev/

The GCS has been created using the spin.maintainers@gmail.com account.

fixes #1

@ThorstenHans ThorstenHans changed the title dd Google Custom Search for spinkube.dev Add Google Custom Search for spinkube.dev Mar 8, 2024
Copy link
Contributor

@vdice vdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GCS ID update looks good to me -- I'm assuming this isn't testable locally? (Looking at this: https://github.com/spinkube/documentation/blob/main/hugo.toml#L126 which seems like it'd use a diff searching engine anyways?)

nit: I kind of like the toml indentations for readability but not a strong opinion. Defer to any others who might have one.

@ThorstenHans
Copy link
Contributor Author

ThorstenHans commented Mar 8, 2024

Oh, so that was "Better TOML".

I'm happy to revert the indention. However, I don't have access to a computer at the moment. Can update this PR tomorrow morning CET

@ThorstenHans
Copy link
Contributor Author

ThorstenHans commented Mar 8, 2024

GCS ID update looks good to me -- I'm assuming this isn't testable locally? (Looking at this: https://github.com/spinkube/documentation/blob/main/hugo.toml#L126 which seems like it'd use a diff searching engine anyways?)

I've changed the visualization of the search results to be in-place instead of an overlay (modal dialog) which was a kind of distracting.

Indexing of the pages can take a while (according to GCS docs)

An instance of Google Custom Search (GCS) has been added and configured to index contents from *.spinkube.dev/*

fixes #1

Signed-off-by: Thorsten Hans <thorsten.hans@fermyon.com>
@tpmccallum tpmccallum merged commit 8acf31b into main Mar 11, 2024
@tpmccallum tpmccallum deleted the feature/google-custom-search branch March 11, 2024 01:19
@tpmccallum
Copy link
Contributor

Thanks @ThorstenHans @vdice

@vdice
Copy link
Contributor

vdice commented Mar 11, 2024

Is custom search working for y'all as you'd expect?

When I type in terms like 'shim', 'kubernetes', 'plugin', etc, I get no results. Typing 'spin' does give one result: a link to the spinkube.dev website. Wondering if I have a cached version or something, so thought I'd inquire.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable internal search
3 participants