Build the docs on PRs #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit CI will run also on PRs targeting main. Artifact publishing and deployment is disabled using an if condition Signed-off-by: Thorsten Hans <thorsten.hans@fermyon.com>
vdice
reviewed
Mar 18, 2024
There was a problem hiding this comment.
I might prefer we create a separate workflow for PRs for a few reasons:
- This workflow currently uses a concurrency config to prevent simultaneous deploys... as configured, this would mean PR runs could/would queue
- There are some token permissions that we wouldn't necessarily want PRs to inherit (admittedly, a fix for this is to move those under the
deployjob which would be gated on pushes to main) - If/when we do find a PR preview strategy, I imagine it would make sense for that to be used in a separate PR workflow as well.
WDYT?
I'd also be fine with something like this in the near-term if some of the 'blockers' from above (1 and 2) can be addressed.
|
I'm also happy with a dedicated workflow. Will go ahead and split it, which will automatically resolve the other finding |
Signed-off-by: Thorsten Hans <thorsten.hans@fermyon.com>
Signed-off-by: Thorsten Hans <thorsten.hans@fermyon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, the Deploy to GitHub Pages action is also executed within PRs targeting
main.Publishing preview builds on GitHub pages from PRs is not officially supported. However, this would - at least - act as a build verification.