Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hello world blog post #104

Merged
merged 1 commit into from Mar 13, 2024
Merged

hello world blog post #104

merged 1 commit into from Mar 13, 2024

Conversation

endocrimes
Copy link
Contributor

Partially superseeds #65 (does not include quickstart changes)

@endocrimes
Copy link
Contributor Author

(Review not required from everyone, but tagging a sample of maintainers to give folks a chance to correct any messaging of individual projects)

macolso
macolso reviewed Mar 12, 2024
View reviewed changes
Copy link
Contributor

@macolso macolso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Left a few small suggestions on phrasing, primarily in the serverless section

content/en/blog/news/first-post/index.md Outdated Show resolved Hide resolved
content/en/blog/news/first-post/index.md Outdated Show resolved Hide resolved
content/en/blog/news/first-post/index.md Outdated Show resolved Hide resolved
content/en/blog/news/first-post/index.md Outdated Show resolved Hide resolved
content/en/blog/news/first-post/index.md Outdated Show resolved Hide resolved
content/en/blog/news/first-post/index.md Outdated Show resolved Hide resolved
content/en/blog/news/first-post/index.md Show resolved Hide resolved
radu-matei
radu-matei approved these changes Mar 12, 2024
View reviewed changes
Copy link
Member

@radu-matei radu-matei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few non-blocking comments, this looks great, thank you for putting this together!

content/en/blog/news/first-post/index.md Outdated Show resolved Hide resolved
content/en/blog/news/first-post/index.md Outdated Show resolved Hide resolved
bacongobbler
bacongobbler previously requested changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@bacongobbler bacongobbler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had some small grammatical nitpicks here and there, but overall the content here looks great!

content/en/blog/news/first-post/index.md Outdated Show resolved Hide resolved
content/en/blog/news/first-post/index.md Outdated Show resolved Hide resolved
content/en/blog/news/first-post/index.md Show resolved Hide resolved
content/en/blog/news/first-post/index.md Show resolved Hide resolved
content/en/blog/news/first-post/index.md Outdated Show resolved Hide resolved
@spinkube spinkube deleted a comment from bacongobbler Mar 12, 2024
tpmccallum
tpmccallum reviewed Mar 13, 2024
View reviewed changes
Copy link
Contributor

@tpmccallum tpmccallum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic @endocrimes
Some suggestions with a copy editor's hat on.

content/en/blog/news/first-post/index.md Outdated Show resolved Hide resolved
content/en/blog/news/first-post/index.md Outdated Show resolved Hide resolved
content/en/blog/news/first-post/index.md Outdated Show resolved Hide resolved
content/en/blog/news/first-post/index.md Outdated Show resolved Hide resolved
content/en/blog/news/first-post/index.md Outdated Show resolved Hide resolved
content/en/blog/news/first-post/index.md Outdated Show resolved Hide resolved
content/en/blog/news/first-post/index.md Outdated Show resolved Hide resolved
content/en/blog/news/first-post/index.md Show resolved Hide resolved
content/en/blog/news/first-post/index.md Show resolved Hide resolved
content/en/blog/news/first-post/index.md Show resolved Hide resolved
@tpmccallum tpmccallum mentioned this pull request Mar 13, 2024
Closed
tpmccallum
tpmccallum reviewed Mar 13, 2024
View reviewed changes
content/en/blog/news/first-post/index.md Outdated Show resolved Hide resolved
content/en/blog/news/first-post/index.md Outdated Show resolved Hide resolved
content/en/blog/news/first-post/index.md Show resolved Hide resolved
content/en/blog/news/first-post/index.md Show resolved Hide resolved
content/en/blog/news/first-post/index.md Show resolved Hide resolved
content/en/blog/news/first-post/index.md Show resolved Hide resolved
content/en/blog/news/first-post/index.md Show resolved Hide resolved
content/en/blog/news/first-post/index.md Show resolved Hide resolved
content/en/blog/news/first-post/index.md Show resolved Hide resolved
content/en/blog/news/first-post/index.md Show resolved Hide resolved
tpmccallum
tpmccallum reviewed Mar 13, 2024
View reviewed changes
Copy link
Contributor

@tpmccallum tpmccallum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had another read through this afternoon - fantastic article. There are just a few inline changes added for your convenience.

@endocrimes endocrimes force-pushed the intro-spinkube branch 2 times, most recently from c2b8482 to c897cc0 Compare March 13, 2024 14:53
@endocrimes
hello world blog post
6e96021 
Signed-off-by: Danielle Lancashire <dani@builds.terrible.systems>
@endocrimes endocrimes merged commit 7110c0f into main Mar 13, 2024
@endocrimes endocrimes deleted the intro-spinkube branch March 13, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThorstenHans ThorstenHans ThorstenHans left review comments

@bacongobbler bacongobbler bacongobbler left review comments

@tpmccallum tpmccallum tpmccallum left review comments

@radu-matei radu-matei radu-matei approved these changes

@macolso macolso macolso left review comments

@flavio flavio Awaiting requested review from flavio

@devigned devigned Awaiting requested review from devigned

@michelleN michelleN Awaiting requested review from michelleN

@voigt voigt Awaiting requested review from voigt

@0xE282B0 0xE282B0 Awaiting requested review from 0xE282B0

@Mossaka Mossaka Awaiting requested review from Mossaka

@calebschoepp calebschoepp Awaiting requested review from calebschoepp

Assignees
No one assigned
Labels
blog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@endocrimes @ThorstenHans @bacongobbler @tpmccallum @radu-matei @macolso