Update KEDA tutorial & remove instructions for cloning the repo #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cloning the spin-operator repository is not required anymore. This commit updates the KEDA tutorial to reflect those changes Signed-off-by: Thorsten Hans <thorsten.hans@fermyon.com>
vdice
reviewed
Mar 12, 2024
This commit addresses all the bugst and nits discovered by @vdice Signed-off-by: Thorsten Hans <thorsten.hans@fermyon.com>
|
Great findings @vdice I've updated the PR accordingly |
|
Thanks so much @ThorstenHans @vdice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cloning the spin-operator repository is not required anymore. This commit updates the KEDA tutorial to reflect those changes. This modification also required a couple of updates later in the tutorial.
This PR depends on spinkube/spin-operator#169