V0.8.4/specifyips #3330
Open
V0.8.4/specifyips #3330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xumjbn
requested review from
weizhoublue,
ty-dc,
bzsuni,
Icarus9913 and
windsonsea
as code owners
weizhoublue
reviewed
Mar 28, 2024
| @@ -195,6 +196,37 @@ func (im *ipPoolManager) genRandomIP(ctx context.Context, ipPool *spiderpoolv2be | |||
| } | |||
| resIP := availableIPs[0] | |||
|
|
|||
| assignIpMap := make(map[string][]string) | |||
| if anno, ok := pod.Annotations["ipam/ips"]; ok { | |||
There was a problem hiding this comment.
1 it likely does not follow the annotation prefix of the spiderpool
2 does it likely make ip conflict with ip assigned in this way of spiderippool
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing!
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: