Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated yaml and readme #18

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tetracionist
Copy link

Verified that this can be installed on a fresh windows install
Please see changes to Readme and environment.yaml file

Copy link
Owner

@speth speth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it's good to have an independent confirmation that this is working on Windows, and documentation of the minimal option for installing the Microsoft compiler.

- boost-cpp >=1.70
- sundials >=6.0
- cantera==3.0.*
- cxx-compiler==1.7.0
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason for pinning this specific version of cxx-compiler?

Comment on lines +25 to +26
For windows computers make sure that you have installed build tools `C++ build tools <https://visualstudio.microsoft.com/visual-cpp-build-tools>`
This must be installed manually
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
For windows computers make sure that you have installed build tools `C++ build tools <https://visualstudio.microsoft.com/visual-cpp-build-tools>`
This must be installed manually
For Windows computers, make sure that you have installed `Microsoft C++ Build Tools <https://visualstudio.microsoft.com/visual-cpp-build-tools>`_.
This must be installed manually.

@tetracionist
Copy link
Author

tetracionist commented Dec 22, 2023

Thanks, it's good to have an independent confirmation that this is working on Windows, and documentation of the minimal option for installing the Microsoft compiler.

My pleasure, let me do a couple more tests with cxx-compiler as the docs suggest it's supposed to install the compiler which means it should make it easier for "fresh machines".
i.e. it should install g++ on Linux, Clang on Mac and VC on Windows.

I have a few versions of C++ build tools on my PC, the other PC also had a few, but it didn't play nice with 2022 build tools.
I will update the documentation and send some screenshots to this PR.

@tetracionist
Copy link
Author

tetracionist commented Dec 24, 2023

Just tested the install using the GitHub runners on a new branch on my fork. I created a few runners for each Python version and OS.

  • For Ubuntu this works well, cxx-compiler installs g++; scons builds and installs everything no problem.

  • For Mac, I had to make a tweak to get the runner working as the scons install as the platform version was looking for a wheel file for macos-10.9
    Would be keen to understand if other Mac users are experiencing similar issues.

  • For Windows cxx-compiler seems to install msvc but I get path related errors when running scons build. This is not an issue on bare metal if 2019 build tools is installed.

I'll update the readme with some information on this.
If the logs are of interest here's the link:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants