This repository has been archived by the owner on Jul 26, 2023. It is now read-only.
Filter out protected ones from search results #648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since excluding protected routes from searching is a long-proposed feature (#356 #618), the PR trys to provide a way to visually-only limit search results.
While perfect protection is almost impossible which is talked already at #283, some visually tricks may help to at least block "attackers" who do not even know F12.
API results though are filtered as far as the app can, but may still expose filenames of protected files, while the correspoinding protected folder path is hidden.
Further development, such as hiding the search result items that are recognized to be protected ones as long as its path is got, requires error handling fix #647 to differ different errors, so the PR is kept as a draft.