Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getCategoryPages now returns subcategories #523

Merged

Conversation

tstibbs
Copy link
Contributor

@tstibbs tstibbs commented Mar 15, 2023

From the doc changes it looks like I'm significantly changing the API - I'm not, I'm just changing the doc to what the code currently does (or at least, as far as I can tell).

Note for these changes to work locally required #522, for me at least.

Closes #521.

@tstibbs tstibbs changed the title getCategory now returns subcategories getCategoryPages now returns subcategories Mar 15, 2023
@tstibbs tstibbs marked this pull request as ready for review March 15, 2023 16:25
@spencermountain
Copy link
Owner

will put this on dev, then am happy to release it whenever you're through
thanks!

@spencermountain spencermountain changed the base branch from master to dev March 15, 2023 20:48
@spencermountain spencermountain merged commit 27e62b7 into spencermountain:dev Mar 15, 2023
@tstibbs tstibbs deleted the bugfix/api-plugin-subcategories branch March 16, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getCategoryPages doesn't return sub-categories
2 participants