Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix buildrs dll build #772

Merged
merged 30 commits into from
May 26, 2024
Merged

Fix buildrs dll build #772

merged 30 commits into from
May 26, 2024

Conversation

hulto
Copy link
Collaborator

@hulto hulto commented May 5, 2024

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

  • Automatically builds the reflective loader when eldritch builds.
  • Allow users to compile imix as a DLL
  • Enforce successful cargo fmt during testing
  • Formats code
  • TODO: Enforce cargo clippy during testing.

Which issue(s) this PR fixes:

@hulto hulto mentioned this pull request May 6, 2024
Copy link
Collaborator

@Cictrone Cictrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think in the future PRs like this need to be broken up by thing its solving a bit more. theres like 3 different "goals" of the PR which kind of tethers them all together for merge/harder to review.

implants/golem/src/main.rs Show resolved Hide resolved
implants/imix/src/lib.rs Show resolved Hide resolved
implants/imix/src/lib.rs Outdated Show resolved Hide resolved
implants/imix/src/main.rs Show resolved Hide resolved
implants/lib/eldritch/src/lib.rs Show resolved Hide resolved
implants/lib/eldritch/src/random/string_impl.rs Outdated Show resolved Hide resolved
.github/workflows/tests.yml Show resolved Hide resolved
@Cictrone Cictrone merged commit bb49164 into main May 26, 2024
6 checks passed
@Cictrone Cictrone deleted the fix-buildrs-dll-build branch May 26, 2024 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants