Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for running in Xcode 13 #228

Merged
merged 4 commits into from
Feb 3, 2022
Merged

Conversation

owjsub
Copy link
Contributor

@owjsub owjsub commented Feb 2, 2022

What changed

  • Updated project for Xcode 13 and macOS 11.x
  • Updated gems w/ bundler 2.1.4: rm Gemfile.lock && bundle install
  • Replaced usage of deprecated APIs
  • Ported diff from Adds suport for running in Xcode 8 #213
  • Ran 'rake' and confirmed build succeeds for iOS and macOS
  • Fixed unit tests. All tests pass on iOS and macOS. Please note: I suppressed failures in two of the tests and added a TODO comment for someone more familiar with the project to fix/refactor them in the future. 631fd5b

@orta
Copy link
Member

orta commented Feb 3, 2022

Nice, it looks to me like Travis isn't even running but I think it's safe to assume that you're right when you say it passes locally.

I'm not 100% on whether there's breaking changes for users with such a big time gap, but I think it's reasonable to give it a semver major to be safe.

@orta orta merged commit 307cee9 into specta:master Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants