Fix Xcode 11 warnings. Use angled brackets for framework headers

specta · Apr 12, 2021 · 478037e · 478037e
1 parent fc2dd8b
commit 478037e
Show file tree

Hide file tree

Showing 37 changed files with 95 additions and 107 deletions.
diff --git a/Expecta.xcodeproj/project.pbxproj b/Expecta.xcodeproj/project.pbxproj
@@ -1216,7 +1216,7 @@
 			attributes = {
 				CLASSPREFIX = EXP;
 				LastTestingUpgradeCheck = 0630;
-				LastUpgradeCheck = 1010;
+				LastUpgradeCheck = 1250;
 				ORGANIZATIONNAME = "Peter Jihoon Kim";
 				TargetAttributes = {
 					908379101A8B9660009844DA = {
@@ -1232,6 +1232,7 @@
 			developmentRegion = English;
 			hasScannedForEncodings = 0;
 			knownRegions = (
+				English,
 				en,
 			);
 			mainGroup = E9ACDF0113B2DD520010F4D7;
@@ -1992,6 +1993,7 @@
 				CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
 				CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES;
 				CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
+				CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER = YES;
 				CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
 				CLANG_WARN_STRICT_PROTOTYPES = YES;
 				CLANG_WARN_SUSPICIOUS_MOVE = YES;
@@ -2191,6 +2193,7 @@
 				CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
 				CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES;
 				CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
+				CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER = YES;
 				CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
 				CLANG_WARN_STRICT_PROTOTYPES = YES;
 				CLANG_WARN_SUSPICIOUS_MOVE = YES;
@@ -2238,6 +2241,7 @@
 				CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
 				CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES;
 				CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
+				CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER = YES;
 				CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
 				CLANG_WARN_STRICT_PROTOTYPES = YES;
 				CLANG_WARN_SUSPICIOUS_MOVE = YES;

diff --git a/Expecta.xcodeproj/xcshareddata/xcschemes/Expecta-iOS.xcscheme b/Expecta.xcodeproj/xcshareddata/xcschemes/Expecta-iOS.xcscheme
@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <Scheme
-   LastUpgradeVersion = "1010"
+   LastUpgradeVersion = "1250"
    version = "1.3">
    <BuildAction
       parallelizeBuildables = "YES"
@@ -27,6 +27,15 @@
       selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
       selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
       shouldUseLaunchSchemeArgsEnv = "YES">
+      <MacroExpansion>
+         <BuildableReference
+            BuildableIdentifier = "primary"
+            BlueprintIdentifier = "908379101A8B9660009844DA"
+            BuildableName = "Expecta.framework"
+            BlueprintName = "Expecta-iOS"
+            ReferencedContainer = "container:Expecta.xcodeproj">
+         </BuildableReference>
+      </MacroExpansion>
       <Testables>
          <TestableReference
             skipped = "NO">
@@ -39,17 +48,6 @@
             </BuildableReference>
          </TestableReference>
       </Testables>
-      <MacroExpansion>
-         <BuildableReference
-            BuildableIdentifier = "primary"
-            BlueprintIdentifier = "908379101A8B9660009844DA"
-            BuildableName = "Expecta.framework"
-            BlueprintName = "Expecta-iOS"
-            ReferencedContainer = "container:Expecta.xcodeproj">
-         </BuildableReference>
-      </MacroExpansion>
-      <AdditionalOptions>
-      </AdditionalOptions>
    </TestAction>
    <LaunchAction
       buildConfiguration = "Debug"
@@ -70,8 +68,6 @@
             ReferencedContainer = "container:Expecta.xcodeproj">
          </BuildableReference>
       </MacroExpansion>
-      <AdditionalOptions>
-      </AdditionalOptions>
    </LaunchAction>
    <ProfileAction
       buildConfiguration = "Release"

diff --git a/Expecta.xcodeproj/xcshareddata/xcschemes/Expecta.xcscheme b/Expecta.xcodeproj/xcshareddata/xcschemes/Expecta.xcscheme
@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <Scheme
-   LastUpgradeVersion = "1010"
+   LastUpgradeVersion = "1250"
    version = "1.3">
    <BuildAction
       parallelizeBuildables = "YES"
@@ -27,6 +27,15 @@
       selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
       selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
       shouldUseLaunchSchemeArgsEnv = "YES">
+      <MacroExpansion>
+         <BuildableReference
+            BuildableIdentifier = "primary"
+            BlueprintIdentifier = "908379781A8B972C009844DA"
+            BuildableName = "Expecta.framework"
+            BlueprintName = "Expecta"
+            ReferencedContainer = "container:Expecta.xcodeproj">
+         </BuildableReference>
+      </MacroExpansion>
       <Testables>
          <TestableReference
             skipped = "NO">
@@ -39,17 +48,6 @@
             </BuildableReference>
          </TestableReference>
       </Testables>
-      <MacroExpansion>
-         <BuildableReference
-            BuildableIdentifier = "primary"
-            BlueprintIdentifier = "908379781A8B972C009844DA"
-            BuildableName = "Expecta.framework"
-            BlueprintName = "Expecta"
-            ReferencedContainer = "container:Expecta.xcodeproj">
-         </BuildableReference>
-      </MacroExpansion>
-      <AdditionalOptions>
-      </AdditionalOptions>
    </TestAction>
    <LaunchAction
       buildConfiguration = "Debug"
@@ -70,8 +68,6 @@
             ReferencedContainer = "container:Expecta.xcodeproj">
          </BuildableReference>
       </MacroExpansion>
-      <AdditionalOptions>
-      </AdditionalOptions>
    </LaunchAction>
    <ProfileAction
       buildConfiguration = "Release"

diff --git a/Expecta.xcodeproj/xcshareddata/xcschemes/libExpecta-iOS.xcscheme b/Expecta.xcodeproj/xcshareddata/xcschemes/libExpecta-iOS.xcscheme
@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <Scheme
-   LastUpgradeVersion = "1010"
+   LastUpgradeVersion = "1250"
    version = "1.3">
    <BuildAction
       parallelizeBuildables = "YES"
@@ -39,8 +39,6 @@
             </BuildableReference>
          </TestableReference>
       </Testables>
-      <AdditionalOptions>
-      </AdditionalOptions>
    </TestAction>
    <LaunchAction
       buildConfiguration = "Debug"
@@ -61,8 +59,6 @@
             ReferencedContainer = "container:Expecta.xcodeproj">
          </BuildableReference>
       </MacroExpansion>
-      <AdditionalOptions>
-      </AdditionalOptions>
    </LaunchAction>
    <ProfileAction
       buildConfiguration = "Release"

diff --git a/Expecta.xcodeproj/xcshareddata/xcschemes/libExpecta.xcscheme b/Expecta.xcodeproj/xcshareddata/xcschemes/libExpecta.xcscheme
@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <Scheme
-   LastUpgradeVersion = "1010"
+   LastUpgradeVersion = "1250"
    version = "1.3">
    <BuildAction
       parallelizeBuildables = "YES"
@@ -41,6 +41,15 @@
       selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
       selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
       shouldUseLaunchSchemeArgsEnv = "YES">
+      <MacroExpansion>
+         <BuildableReference
+            BuildableIdentifier = "primary"
+            BlueprintIdentifier = "E9ACDF0B13B2DD520010F4D7"
+            BuildableName = "libExpecta.a"
+            BlueprintName = "libExpecta"
+            ReferencedContainer = "container:Expecta.xcodeproj">
+         </BuildableReference>
+      </MacroExpansion>
       <Testables>
          <TestableReference
             skipped = "NO">
@@ -53,17 +62,6 @@
             </BuildableReference>
          </TestableReference>
       </Testables>
-      <MacroExpansion>
-         <BuildableReference
-            BuildableIdentifier = "primary"
-            BlueprintIdentifier = "E9ACDF0B13B2DD520010F4D7"
-            BuildableName = "libExpecta.a"
-            BlueprintName = "libExpecta"
-            ReferencedContainer = "container:Expecta.xcodeproj">
-         </BuildableReference>
-      </MacroExpansion>
-      <AdditionalOptions>
-      </AdditionalOptions>
    </TestAction>
    <LaunchAction
       buildConfiguration = "Debug"
@@ -84,8 +82,6 @@
             ReferencedContainer = "container:Expecta.xcodeproj">
          </BuildableReference>
       </MacroExpansion>
-      <AdditionalOptions>
-      </AdditionalOptions>
    </LaunchAction>
    <ProfileAction
       buildConfiguration = "Release"

diff --git a/Expecta/EXPBlockDefinedMatcher.h b/Expecta/EXPBlockDefinedMatcher.h
@@ -7,8 +7,8 @@
 //
 
 #import <Foundation/Foundation.h>
-#import "EXPMatcher.h"
-#import "EXPDefines.h"
+#import <Expecta/EXPMatcher.h>
+#import <Expecta/EXPDefines.h>
 
 @interface EXPBlockDefinedMatcher : NSObject <EXPMatcher> {
   EXPBoolBlock prerequisiteBlock;

diff --git a/Expecta/EXPExpect.h b/Expecta/EXPExpect.h
@@ -1,6 +1,6 @@
 #import <Foundation/Foundation.h>
-#import "EXPMatcher.h"
-#import "EXPDefines.h"
+#import <Expecta/EXPMatcher.h>
+#import <Expecta/EXPDefines.h>
 
 @interface EXPExpect : NSObject {
   EXPIdBlock _actualBlock;

diff --git a/Expecta/EXPExpect.m b/Expecta/EXPExpect.m
@@ -1,6 +1,6 @@
 #import "EXPExpect.h"
 #import "NSObject+Expecta.h"
-#import "Expecta.h"
+#import <Expecta/Expecta.h>
 #import "EXPUnsupportedObject.h"
 #import "EXPMatcher.h"
 #import "EXPBlockDefinedMatcher.h"

diff --git a/Expecta/ExpectaSupport.h b/Expecta/ExpectaSupport.h
@@ -1,5 +1,5 @@
-#import "EXPExpect.h"
-#import "EXPBlockDefinedMatcher.h"
+#import <Expecta/EXPExpect.h>
+#import <Expecta/EXPBlockDefinedMatcher.h>
 
 #ifdef __cplusplus
 extern "C" {

diff --git a/Expecta/Matchers/EXPMatchers+beCloseTo.h b/Expecta/Matchers/EXPMatchers+beCloseTo.h
@@ -1,4 +1,4 @@
-#import "Expecta.h"
+#import <Expecta/Expecta.h>
 
 EXPMatcherInterface(_beCloseToWithin, (id expected, id within));
 EXPMatcherInterface(beCloseToWithin, (id expected, id within));

diff --git a/Expecta/Matchers/EXPMatchers+beFalsy.h b/Expecta/Matchers/EXPMatchers+beFalsy.h
@@ -1,3 +1,3 @@
-#import "Expecta.h"
+#import <Expecta/Expecta.h>
 
 EXPMatcherInterface(beFalsy, (void));
diff --git a/Expecta/Matchers/EXPMatchers+beGreaterThan.h b/Expecta/Matchers/EXPMatchers+beGreaterThan.h
@@ -1,4 +1,4 @@
-#import "Expecta.h"
+#import <Expecta/Expecta.h>
 
 EXPMatcherInterface(_beGreaterThan, (id expected));
 EXPMatcherInterface(beGreaterThan, (id expected));

diff --git a/Expecta/Matchers/EXPMatchers+beGreaterThanOrEqualTo.h b/Expecta/Matchers/EXPMatchers+beGreaterThanOrEqualTo.h
@@ -1,4 +1,4 @@
-#import "Expecta.h"
+#import <Expecta/Expecta.h>
 
 EXPMatcherInterface(_beGreaterThanOrEqualTo, (id expected));
 EXPMatcherInterface(beGreaterThanOrEqualTo, (id expected));

diff --git a/Expecta/Matchers/EXPMatchers+beIdenticalTo.h b/Expecta/Matchers/EXPMatchers+beIdenticalTo.h
@@ -1,4 +1,4 @@
-#import "Expecta.h"
+#import <Expecta/Expecta.h>
 
 EXPMatcherInterface(_beIdenticalTo, (void *expected));
 EXPMatcherInterface(beIdenticalTo, (void *expected)); // to aid code completion

diff --git a/Expecta/Matchers/EXPMatchers+beInTheRangeOf.h b/Expecta/Matchers/EXPMatchers+beInTheRangeOf.h
@@ -1,4 +1,4 @@
-#import "Expecta.h"
+#import <Expecta/Expecta.h>
 
 EXPMatcherInterface(_beInTheRangeOf, (id expectedLowerBound, id expectedUpperBound));
 EXPMatcherInterface(beInTheRangeOf, (id expectedLowerBound, id expectedUpperBound));

diff --git a/Expecta/Matchers/EXPMatchers+beInstanceOf.h b/Expecta/Matchers/EXPMatchers+beInstanceOf.h
@@ -1,4 +1,4 @@
-#import "Expecta.h"
+#import <Expecta/Expecta.h>
 
 EXPMatcherInterface(beInstanceOf,   (Class expected));
 EXPMatcherInterface(beAnInstanceOf, (Class expected));

diff --git a/Expecta/Matchers/EXPMatchers+beKindOf.h b/Expecta/Matchers/EXPMatchers+beKindOf.h
@@ -1,4 +1,4 @@
-#import "Expecta.h"
+#import <Expecta/Expecta.h>
 
 EXPMatcherInterface(beKindOf,  (Class expected));
 EXPMatcherInterface(beAKindOf, (Class expected));
diff --git a/Expecta/Matchers/EXPMatchers+beLessThan.h b/Expecta/Matchers/EXPMatchers+beLessThan.h
@@ -1,4 +1,4 @@
-#import "Expecta.h"
+#import <Expecta/Expecta.h>
 
 EXPMatcherInterface(_beLessThan, (id expected));
 EXPMatcherInterface(beLessThan, (id expected));

diff --git a/Expecta/Matchers/EXPMatchers+beLessThanOrEqualTo.h b/Expecta/Matchers/EXPMatchers+beLessThanOrEqualTo.h
@@ -1,4 +1,4 @@
-#import "Expecta.h"
+#import <Expecta/Expecta.h>
 
 EXPMatcherInterface(_beLessThanOrEqualTo, (id expected));
 EXPMatcherInterface(beLessThanOrEqualTo, (id expected));

diff --git a/Expecta/Matchers/EXPMatchers+beNil.h b/Expecta/Matchers/EXPMatchers+beNil.h
@@ -1,4 +1,4 @@
-#import "Expecta.h"
+#import <Expecta/Expecta.h>
 
 EXPMatcherInterface(beNil, (void));
 EXPMatcherInterface(beNull, (void));
diff --git a/Expecta/Matchers/EXPMatchers+beSubclassOf.h b/Expecta/Matchers/EXPMatchers+beSubclassOf.h
@@ -1,4 +1,4 @@
-#import "Expecta.h"
+#import <Expecta/Expecta.h>
 
 EXPMatcherInterface(beSubclassOf,  (Class expected));
 EXPMatcherInterface(beASubclassOf, (Class expected));
diff --git a/Expecta/Matchers/EXPMatchers+beSupersetOf.h b/Expecta/Matchers/EXPMatchers+beSupersetOf.h
@@ -1,4 +1,4 @@
-#import "Expecta.h"
+#import <Expecta/Expecta.h>
 
 EXPMatcherInterface(beSupersetOf, (id subset));
 
diff --git a/Expecta/Matchers/EXPMatchers+beTruthy.h b/Expecta/Matchers/EXPMatchers+beTruthy.h
@@ -1,3 +1,3 @@
-#import "Expecta.h"
+#import <Expecta/Expecta.h>
 
 EXPMatcherInterface(beTruthy, (void));
diff --git a/Expecta/Matchers/EXPMatchers+beginWith.h b/Expecta/Matchers/EXPMatchers+beginWith.h
@@ -1,4 +1,4 @@
-#import "Expecta.h"
+#import <Expecta/Expecta.h>
 
 EXPMatcherInterface(beginWith, (id expected));
 EXPMatcherInterface(startWith, (id expected));
diff --git a/Expecta/Matchers/EXPMatchers+conformTo.h b/Expecta/Matchers/EXPMatchers+conformTo.h
@@ -1,3 +1,3 @@
-#import "Expecta.h"
+#import <Expecta/Expecta.h>
 
 EXPMatcherInterface(conformTo, (Protocol *expected));
diff --git a/Expecta/Matchers/EXPMatchers+contain.h b/Expecta/Matchers/EXPMatchers+contain.h
@@ -1,4 +1,4 @@
-#import "Expecta.h"
+#import <Expecta/Expecta.h>
 
 EXPMatcherInterface(_contain, (id expected));
 EXPMatcherInterface(contain, (id expected)); // to aid code completion

diff --git a/Expecta/Matchers/EXPMatchers+endWith.h b/Expecta/Matchers/EXPMatchers+endWith.h
@@ -1,3 +1,3 @@
-#import "Expecta.h"
+#import <Expecta/Expecta.h>
 
 EXPMatcherInterface(endWith, (id expected));
diff --git a/Expecta/Matchers/EXPMatchers+equal.h b/Expecta/Matchers/EXPMatchers+equal.h
@@ -1,4 +1,4 @@
-#import "Expecta.h"
+#import <Expecta/Expecta.h>
 
 EXPMatcherInterface(_equal, (id expected));
 EXPMatcherInterface(equal, (id expected)); // to aid code completion

diff --git a/Expecta/Matchers/EXPMatchers+haveCountOf.h b/Expecta/Matchers/EXPMatchers+haveCountOf.h
@@ -1,4 +1,4 @@
-#import "Expecta.h"
+#import <Expecta/Expecta.h>
 
 EXPMatcherInterface(haveCountOf,   (NSUInteger expected));
 EXPMatcherInterface(haveCount,     (NSUInteger expected));

diff --git a/Expecta/Matchers/EXPMatchers+match.h b/Expecta/Matchers/EXPMatchers+match.h
@@ -1,3 +1,3 @@
-#import "Expecta.h"
+#import <Expecta/Expecta.h>
 
 EXPMatcherInterface(match, (NSString *expected));
diff --git a/Expecta/Matchers/EXPMatchers+postNotification.h b/Expecta/Matchers/EXPMatchers+postNotification.h
@@ -1,4 +1,4 @@
-#import "Expecta.h"
+#import <Expecta/Expecta.h>
 
 EXPMatcherInterface(postNotification, (id expectedNotification));
 EXPMatcherInterface(notify, (id expectedNotification));
diff --git a/Expecta/Matchers/EXPMatchers+raise.h b/Expecta/Matchers/EXPMatchers+raise.h
@@ -1,4 +1,4 @@
-#import "Expecta.h"
+#import <Expecta/Expecta.h>
 
 EXPMatcherInterface(raise, (NSString *expectedExceptionName));
 #define raiseAny() raise(nil)
diff --git a/Expecta/Matchers/EXPMatchers+raiseWithReason.h b/Expecta/Matchers/EXPMatchers+raiseWithReason.h
@@ -1,3 +1,3 @@
-#import "Expecta.h"
+#import <Expecta/Expecta.h>
 
 EXPMatcherInterface(raiseWithReason, (NSString *expectedExceptionName, NSString *expectedReason));
diff --git a/Expecta/Matchers/EXPMatchers+respondTo.h b/Expecta/Matchers/EXPMatchers+respondTo.h
@@ -1,3 +1,3 @@
-#import "Expecta.h"
+#import <Expecta/Expecta.h>
 
 EXPMatcherInterface(respondTo, (SEL expected));