Start normalizing props for DUI3 (CNX-9169) #3385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamhathcock
changed the title
JR-Morgan
requested changes
May 9, 2024
DUI3-DX/Connectors/Rhino/Speckle.Connectors.Rhino7/DependencyInjection/RhinoPlugin.cs
Outdated
Show resolved
Hide resolved
DUI3-DX/Connectors/Rhino/Speckle.Connectors.Rhino7/Plugin/Speckle.Connectors.Rhino7Command.cs
Outdated
Show resolved
Hide resolved
DUI3-DX/Connectors/Rhino/Speckle.Connectors.Rhino7/Plugin/Speckle.Connectors.Rhino7Plugin.cs
Outdated
Show resolved
Hide resolved
...-DX/Converters/ArcGIS/Speckle.Converters.ArcGIS3/Layers/PointcloudLayerToSpeckleConverter.cs
Outdated
Show resolved
Hide resolved
DUI3-DX/Converters/ArcGIS/Speckle.Converters.ArcGIS3/Layers/VectorLayerToHostConverter.cs
Show resolved
Hide resolved
DUI3-DX/DUI3/Speckle.Connectors.DUI/Models/Card/SendFilter/DirectSelectionSendFilter.cs
Outdated
Show resolved
Hide resolved
DUI3-DX/Objects/Speckle.Objects.Common/Speckle.Objects.Common.csproj
Outdated
Show resolved
Hide resolved
DUI3-DX/Sdk/Speckle.Connectors.Utils/Speckle.Connectors.Utils.csproj
Outdated
Show resolved
Hide resolved
DUI3-DX/Sdk/Speckle.Converters.Common.DependencyInjection/ToHost/ToHostConverterWithFallback.cs
Outdated
Show resolved
Hide resolved
JR-Morgan
requested changes
May 9, 2024
DUI3-DX/Connectors/Rhino/Speckle.Connectors.Rhino7/Plugin/Speckle.Connectors.Rhino7Plugin.cs
Outdated
Show resolved
Hide resolved
DUI3-DX/Connectors/Rhino/Speckle.Connectors.Rhino7/Bindings/RhinoBasicConnectorBinding.cs
Outdated
Show resolved
Hide resolved
...-DX/Converters/ArcGIS/Speckle.Converters.ArcGIS3/Layers/PointcloudLayerToSpeckleConverter.cs
Outdated
Show resolved
Hide resolved
|
updated again @JR-Morgan 😬 |
JR-Morgan
requested changes
May 10, 2024
...Connectors/Autocad/Speckle.Connectors.AutocadShared/Bindings/AutocadBasicConnectorBinding.cs
Outdated
Show resolved
Hide resolved
DUI3-DX/Connectors/Revit/Speckle.Connectors.RevitShared/Bindings/SelectionBinding.cs
Outdated
Show resolved
Hide resolved
DUI3-DX/Connectors/Revit/Speckle.Connectors.RevitShared/Bindings/SendBinding.cs
Outdated
Show resolved
Hide resolved
DUI3-DX/Connectors/Rhino/Speckle.Connectors.Rhino7/Bindings/RhinoBasicConnectorBinding.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Is it dup with Speckle.Connectors.Utils? seems to me general enough to have it on Core
There was a problem hiding this comment.
This is off the alpha branch. I didn't make a new project?
There was a problem hiding this comment.
This class is duped between the two projects.
After discussing this a little with Adam, we're thinking this duplication will be resolved when we look at changing our common/sdk projects.
I don't think we should pollute Core with opinionated, non essential, non-API related features
JR-Morgan
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving stuff from csprojs to props file for better management