New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use https #953
base: development/v3.0.1
Are you sure you want to change the base?
Use https #953
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The first URL reference change is fine, but the RDF needs to stay as "http" not "https"
@@ -191,7 +190,7 @@ A conjunctive license can be expressed in RDF via a `<spdx:ConjunctiveLicenseSet | |||
|
|||
```text | |||
<spdx:ConjunctiveLicenseSet> | |||
<spdx:member rdf:resource="http://spdx.org/licenses/GPL-2.0-only"/> | |||
<spdx:member rdf:resource="https://spdx.org/licenses/GPL-2.0-only"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This actually needs to stay "http" not "https" since the RDF URI specifies it that way. Adding the "s" would break compatibility with some RDF oriented tools.
@@ -210,7 +209,7 @@ A disjunctive license can be expressed in RDF via a `<spdx:DisjunctiveLicenseSet | |||
|
|||
```text | |||
<spdx:DisjunctiveLicenseSet> | |||
<spdx:member rdf:resource="http://spdx.org/licenses/GPL-2.0-only"/> | |||
<spdx:member rdf:resource="https://spdx.org/licenses/GPL-2.0-only"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above
@@ -253,6 +252,6 @@ A License Exception can be expressed in RDF via a `<spdx:LicenseException>` elem | |||
<spdx:name>"But I Don't Want To" Exception</spdx:name> | |||
<spdx:licenseExceptionId>SPDXRef-ButIdDontWantToException</spdx:licenseExceptionId> | |||
<rdf:type rdf:resource | |||
="http://spdx.org/rdf/terms#LicenseException"/> | |||
="https://spdx.org/rdf/terms#LicenseException"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above
Signed-off-by: Marc-Etienne Vargenau <marc-etienne.vargenau@nokia.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @vargenau
No description provided.