New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update publish_v3.yml to alias "v3.0" (and later "v3.0.1") as "latest" #950
base: development/v3.0.1
Are you sure you want to change the base?
Conversation
Update `alias` argument for `mike deploy` to have `v3.0` as the `latest` `v3.0` was aliased as `v3-draft`, so `v2.3` still keep the `latest` alias. Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@licquia - could you do a quick review |
Co-authored-by: Jeff Licquia <jeff@licquia.org> Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
I'm not sure if we like to merge this at this time, since it has the tag Normally, See more thoughts on this in next comment. |
I'm try to rethink and find what more logical is:
If this is correct and agreed:
-- Note: The content of (2)-(3) is PR #950 before the merge with #934 (this PR at the commit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With this change, we will be advertising 3.0.1 as the latest; if we want to change that, we can do that with a slight change and some manual runs of mike. But I think we should go forward with this at least as a first step.
.github/workflows/publish_v3.yml
:alias
argument formike deploy
to havev3.0
as thelatest
v3.0
was aliased asv3-draft
, sov2.3
still occupied thelatest
alias.mkdocs.yml
:mike
section: Addcanonical_version
configuration aslatest
latest
appear near the first in search engine, among other versions, see https://github.com/jimporter/mike#configurationWill fix #949