Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix infinite loops in memlet path when a scope cycle is added #1559

Merged
merged 1 commit into from Apr 26, 2024
Merged

Fix infinite loops in memlet path when a scope cycle is added #1559

merged 1 commit into from Apr 26, 2024

Conversation

tbennun
Copy link
Collaborator

@tbennun tbennun commented Apr 25, 2024

Fixes #1558

@tbennun tbennun requested a review from tim0s April 25, 2024 18:02
@tbennun tbennun mentioned this pull request Apr 25, 2024
Closed
tim0s
tim0s approved these changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@tim0s tim0s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me :)

@tim0s tim0s added this pull request to the merge queue Apr 26, 2024
Merged via the queue into master with commit f01b937 Apr 26, 2024
9 checks passed
@tim0s tim0s deleted the cycle-check branch April 26, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tim0s tim0s tim0s approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add_edge hangs when trying to form a loop
2 participants
@tbennun @tim0s