Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NOAA/NASA pyFV3 CI on every commit #1478

Merged
merged 34 commits into from May 9, 2024
Merged

NOAA/NASA pyFV3 CI on every commit #1478

merged 34 commits into from May 9, 2024

Conversation

FlorianDeconinck
Copy link
Contributor

@FlorianDeconinck FlorianDeconinck commented Dec 12, 2023 •
edited

Follow up of #1460

  • Fixed the ci script (including git checkout issues around selecting the correct dace)
  • Move D_SW to execute only on rank 0 to avoid rebuild
  • Swapped Rieman Solver on C-grid for D-grid for better coverage

WARNING: this PR is blocked by #1477
WARNING: this PR is blocked by #1568

@FlorianDeconinck FlorianDeconinck changed the title Fix/pace ci NOAA/NASA Pace build CI on every commit Dec 12, 2023
@tbennun tbennun added the no-ci label Dec 13, 2023
@FlorianDeconinck
Copy link
Contributor Author

@BenWeber42 / @phschaad / @tbennun

Gents,
The bug on compilation has been solved, so I am resuming work on this. Unfortunately, it seems settings have changed and the Github actions cannot reach outside of the SPCL organization, which means the original strategy is no longer functioning (we pull from NOAA).

Thoughts?

@FlorianDeconinck
Copy link
Contributor Author

This raised a true bug (#1568) before we can merge it

@FlorianDeconinck FlorianDeconinck changed the title NOAA/NASA Pace build CI on every commit NOAA/NASA pyFV3 build CI on every commit May 9, 2024
@FlorianDeconinck FlorianDeconinck changed the title NOAA/NASA pyFV3 build CI on every commit NOAA/NASA pyFV3 CI on every commit May 9, 2024
@FlorianDeconinck FlorianDeconinck marked this pull request as ready for review May 9, 2024 13:49
@tbennun tbennun removed the no-ci label May 9, 2024
@FlorianDeconinck
Copy link
Contributor Author

Takes ~4mn to run once launched.

@tbennun tbennun self-requested a review May 9, 2024 21:06
@tbennun tbennun added this pull request to the merge queue May 9, 2024
Merged via the queue into spcl:master with commit ee5a6df May 9, 2024
10 checks passed
@FlorianDeconinck FlorianDeconinck deleted the fix/pace_ci branch May 9, 2024 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbennun tbennun tbennun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@FlorianDeconinck @tbennun