Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#159 Update dependencies #160

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

#159 Update dependencies #160

wants to merge 6 commits into from

Conversation

michaelw85
Copy link
Contributor

@michaelw85 michaelw85 commented May 15, 2024

Resolves #159
Update Symfony dependencies to v7.
Update PHP Unit to V11

Note:
To be able to install in a project with symfony/finder v7 as a dep you need to update yosymfony/resource-watcher.
Unfortunately, this package has not been updated for 4 years even though a PR already exists for some of these updates. I've created my own fork to overcome this issue.
To use the fork add the repo entry to your composer.json, this will allow you to install the updated version 3.1.0

"repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/michaelw85/resource-watcher"
        },
]

@pierresh
Copy link
Contributor

Just an idea, maybe it would be better to include yosymfony/resource-watcher files inside spatie/phpunit-watcher? it is just made of 8 files.

If it makes sense for you, I am ok to submit a PR within the week.

@michaelw85
Copy link
Contributor Author

Just an idea, maybe it would be better to include yosymfony/resource-watcher files inside spatie/phpunit-watcher? it is just made of 8 files.

If it makes sense for you, I am ok to submit a PR within the week.

Sounds like a good idea to me. I personally moved away from this package and reverted back to the pest watcher wich works good enough for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update package dep for symfony console
3 participants