Get permission and role class from method instead of the configuration in traits #2618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Must be the same change for Models?? laravel-permission/src/Models/Role.php Line 70 in 0e593bb |
|
Good point, later I check this. Thanks |
|
still reviewing this and the other PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edit: I push PR #2623 for a more complete solution.
This PR add the (little) ability to override role and permission model class in traits, this can "facilitate" (in a non-exhaustive manner, see discuss #2571) some cases of applications with package used on multiple databases (without the need to modify the configuration at runtime).