Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to disable retrieving fresh model #1295

Closed

Conversation

niekbr
Copy link

@niekbr niekbr commented Apr 21, 2024

I have added an option to the LogOptions in order to disable retrieving a fresh copy of the model. The default behavior is unchanged.

This can be useful if database permissions are limited. For example, when a public facing website is allowed to insert but not select from a privacy-sensitive table.

Let me know if you prefer a different synthax; happy to make improvements

@Gummibeer
Copy link
Collaborator

Hey,
personally not really a case for it - @freekmurze any opinions if you would like to have it merged in and maintain it?
If so I would like to have and see some tests for that one making it clear what it does and what the effects are.

@niekbr
Copy link
Author

niekbr commented Apr 22, 2024

If this solution is not maintainable; it would also be possible to only extract $processingEvent == 'retrieved' to a separate function in order to be able to overwrite it (without adding it to the LogOptions. Let me know what has your preference. I will add tests if you are open for the PR!

@github-actions github-actions bot added the stale label May 14, 2024
@github-actions github-actions bot closed this May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants