Revert: c3b131e

[johnwparent]

Fixes #44163
Reopens #42445

c3b131e

Windows change made out of context that breaks develop should be reverted.

Note: Not entirely clear on the surface why this change breaks linking on Windows, this is a stop gap until we can make the change suggested in #42445 without breaking anything.

[haampie]

It was not out of context, see the failure in github actions.

The issue is you're running that function not in a sub process, so globals are not set. On top of that, if that function call fails, the package is marked installed in the database.

Please fix properly instead of reverting.

[johnwparent]

Alternative solution found, this is no longer necessary.

We run post install hooks on externals, which causes the Windows rpath command to be run on externals as the root package where we previously were not when the Windows rpath was executed as a post install method call. The solution is to just skip the rpathing of externals.