Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iperf3: updated versions from 3.6 to 3.16 #44152

Merged
merged 5 commits into from May 15, 2024
Merged

Conversation

dmagdavector
Copy link
Contributor

@dmagdavector dmagdavector commented May 13, 2024

Spack currently only explicitly has version 3.6 of the iPerf3 package (out of ESnet / LBNL). This makes the default the latest version of 3.16, and adds some other versions (found in some Linux distros, for possible compatibility purposes).

closes #44096

Copy link

spackbot-app bot commented May 13, 2024

Hi @dmagdavector! I noticed that the following package(s) don't yet have maintainers:

  • iperf3

Are you interested in adopting any of these package(s)? If so, simply add the following to the package class:

    maintainers("dmagdavector")

If not, could you contact the developers of this package and see if they are interested? You can quickly see who has worked on a package with spack blame:

$ spack blame iperf3

Thank you for your help! Please don't add maintainers without their consent.

You don't have to be a Spack expert or package developer in order to be a "maintainer," it just gives us a list of users willing to review PRs or debug issues relating to this package. A package can have multiple maintainers; just add a list of GitHub handles of anyone who wants to volunteer.

@wdconinc wdconinc changed the title Update version of iperf3 from 3.6 to 3.16 iperf3: updated versions from 3.6 to 3.16 May 13, 2024
@wdconinc wdconinc self-assigned this May 13, 2024
@wdconinc
Copy link
Contributor

Please feel free to re-request a review when the new version and hash are here. I don't see any other issues.

Spack currently only explicitly has version 3.6 of the iPerf3 package
(out of ESnet / LBNL). This makes the default the latest version of 3.16,
and adds some other versions (found in some Linux distros, for possible
compatibility purposes).
wdconinc
wdconinc previously approved these changes May 13, 2024
Copy link
Contributor

@wdconinc wdconinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for the contribution!

@wdconinc wdconinc enabled auto-merge (squash) May 13, 2024 20:04
auto-merge was automatically disabled May 15, 2024 15:37

Head branch was pushed to by a user without write access

@wdconinc
Copy link
Contributor

Could you file the protobuf change as a separate PR please?

@dmagdavector
Copy link
Contributor Author

Could you file the protobuf change as a separate PR please?

Mis-click / mis-merge on my part: that was my original intention: #44210

@wdconinc
Copy link
Contributor

Can you git revert 4d168d0? Then we can get back to merging this here.

@wdconinc wdconinc enabled auto-merge (squash) May 15, 2024 19:01
@wdconinc wdconinc merged commit 543bd18 into spack:develop May 15, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update version of iperf3 from 3.6 to 3.16
2 participants