Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gitlab CI: Windows Configs #43967

Merged
merged 96 commits into from May 16, 2024
Merged

Conversation

johnwparent
Copy link
Contributor

@johnwparent johnwparent commented May 2, 2024

Support for Gitlab CI on Windows is here!
This PR adds the config changes required to configure and execute Gitlab pipelines running Windows builds on Windows runners using the existing Gitlab CI infrastructure (and newly added Windows side infra).

Adds support for generating child pipelines dispatched to Windows runners
Refactors the relevant pre-scripts, scripts, and post scripts to be compatible with Windows
Adds Windows config section describing Windows jobs
Adds VTK as Windows build stack (to be expanded later).

DO NOT MERGE THIS without validating pre-reqs have been met with a member of the Gitlab CI team and/or @johnwparent, @scottwittenburg, @kwryankrattiger, or @mvandenburgh.
PR Prereqs:

Manual Checks:

  • Validate on protected pipelines
  • Deploy Windows Spack Infrastructure for non staging Gitlab instances.

@spackbot-app spackbot-app bot added core PR affects Spack core functionality defaults gitlab Issues related to gitlab integration labels May 2, 2024
@johnwparent
Copy link
Contributor Author

@scottwittenburg scottwittenburg merged commit 81fe460 into spack:develop May 16, 2024
33 of 35 checks passed
@johnwparent johnwparent added this to the v0.22.1 milestone May 17, 2024
@adamjstewart
Copy link
Member

Excited to see this merged!

I know we're still a long way off from getting all dependencies working, but I would be keen on porting our ML CI stacks to build on Windows someday. Let me know if there's anything I can do to help with the Python on Windows effort.

@johnwparent
Copy link
Contributor Author

Excited to see this merged!

I know we're still a long way off from getting all dependencies working, but I would be keen on porting our ML CI stacks to build on Windows someday. Let me know if there's anything I can do to help with the Python on Windows effort.

Porting all the stacks is the endgame of Spack on Windows, so I'm happy to support any effort doing so. It's not on my radar for the next month or so, but if you have specific packages/stacks you'd like to see, I'd be more than happy to iterate over slack, feel free to DM me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
commands core PR affects Spack core functionality defaults environments gitlab Issues related to gitlab integration new-variant patch tests General test capability(ies) update-package utilities
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'spack install' on Windows errors with DLL trying to link to itself
7 participants