Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Modernize setup and test infrastructure #115

Merged
merged 7 commits into from
Apr 16, 2020
Merged

ENH: Modernize setup and test infrastructure #115

merged 7 commits into from
Apr 16, 2020

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Apr 3, 2020 •
edited

@pllim
MNT: Infrastructure updates.
28129f7 
* Modernize package setup and RTD settings.
* Fix doc build warnings.
* Fix doc broken links.
* Remove mention of PyRAF in doc and most of the code.
* Remove mention of deprecated modules from API doc listing.
* Update year on license and doc page.
@pllim
TST: Improve test matrix.
bb1ec72 
* Modernize Travis settings.
* Add PEP 517 job.
* Add linkcheck job.
* Use pytest-astropy-header in test header.
@pllim pllim added this to the 3.7 milestone Apr 3, 2020
@pllim
Fix Travis script syntax
cd5167d
@pllim
Fix Travis config validation
6c4cc95
@pllim
Polishing test infrastructure.
27692fb 
* Display pytest header correctly.
* Make test generate output in tmpdir, not cwd.
* Close open file in test gracefully.
* Ignore remaining ResourceWarning, see spacetelescope#119.
@pllim pllim force-pushed the moar-setup-cfg branch 2 times, most recently from 073abf2 to 8d46239 Compare April 3, 2020 02:00
@pllim
Copy link
Contributor Author

pllim commented Apr 3, 2020

Hmm. I am unable to get the proper stsci.tools version to display with pytest-astropy-header even though the install log seems to indicate that the version was generated properly. Didn't have this problem with Azure Pipelines nor when running locally. 🤷‍♀

@pllim
Copy link
Contributor Author

pllim commented Apr 3, 2020

This is ready for review. Thanks!

rendinam
rendinam approved these changes Apr 15, 2020
View reviewed changes
Copy link
Collaborator

@rendinam rendinam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't worked through the doc changes, but the functional adjustments don't look scary.

@pllim pllim mentioned this pull request Apr 15, 2020
Closed
@pllim pllim force-pushed the moar-setup-cfg branch 3 times, most recently from 8e8e33a to 427b727 Compare April 15, 2020 14:49
@pllim
Copy link
Contributor Author

pllim commented Apr 15, 2020

Was hoping the PR builder would work. Let's hold off on merging until it works, so you can see the docs.

@pllim
Copy link
Contributor Author

pllim commented Apr 16, 2020

Update: Doc for the PR is at https://stscitools--115.org.readthedocs.build/en/115/ even though it is not reporting back to the PR here.

@pllim
Copy link
Contributor Author

pllim commented Apr 16, 2020

Let's just merge this then, since the rendered doc is fine. I will figure out the RTD webhook with RTD devs separately.

@pllim pllim merged commit 9f18e6b into spacetelescope:master Apr 16, 2020
@pllim pllim deleted the moar-setup-cfg branch April 16, 2020 17:54
@pllim pllim modified the milestones: 3.7, 4.0 Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rendinam rendinam rendinam approved these changes

@jhunkeler jhunkeler Awaiting requested review from jhunkeler

@stsci-hack stsci-hack Awaiting requested review from stsci-hack

@mcara mcara Awaiting requested review from mcara

Assignees
No one assigned
Labels
enhancement tests
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

TST: Add linkcheck and PEP 517 jobs DOC: Remove mention of PyRAF license from code
2 participants
@pllim @rendinam